flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.97k stars 1.6k forks source link

Shifted side panel #2343

Open Pixel48 opened 2 years ago

Pixel48 commented 2 years ago

Flameshot Version

Flameshot v11.0.0 (ad1bf28) Compiled with Qt 5.15.2 winnt: 10.0.19043 windows: 10

Installation Type

Linux, MacOS, or Windows Package manager (apt, pacman, eopkg, choco, brew, ...)

Operating System type and version

Windows 10 21H1

Description

When system screen is expanded to 2nd monitor above, side panel is moved upwards

Steps to reproduce

  1. use windows
  2. connect 2nd monitor and set it up to extend monitor upwards
  3. run flameshot
  4. hit space

Screenshots or screen recordings

obraz

System Information

  1. Windows 10 21H1
  2. obraz

mmahmoudian commented 2 years ago

I tried with the following configuration and couldn't reproduce this on Manjaro Plasma X11. Most probably a Windows-specific issue.

image

Zackhardtoname commented 2 years ago

In case it helps. On Linux, both of my screens would be shifted when taking screenshot unless I run QT_SCREEN_SCALE_FACTORS='' flameshot gui as the screenshot command.

mmahmoudian commented 2 years ago

@Zackhardtoname I think your issue is different as you most probably have fractional scaling on your monitors.

Zackhardtoname commented 2 years ago

@Zackhardtoname I think your issue is different as you most probably have fractional scaling on your monitors.

Thanks for pointing out the difference. My scaling is just 200% though. I am using KDE and i3. I also think the problem was introduced after the latest update because the problem disappeared for a long time.

Pixel48 commented 2 years ago

I think i should mention: I have quite a difference in monitor size obraz

mmahmoudian commented 2 years ago

@Zackhardtoname you are right, 200% should not give you any issues. Can you give us your monitors arrangement so that I try to replicate it.

@Pixel48 thank you for the info, but it was also visible in the screenshot you initially provided 😉 let's see if we can resolve this issue fast

Zackhardtoname commented 2 years ago

Hopefully, it would work.

Screen 0: minimum 8 x 8, current 5120 x 4320, maximum 32767 x 32767
DP-0 disconnected (normal left inverted right x axis y axis)
DP-1 disconnected (normal left inverted right x axis y axis)
HDMI-0 connected 3840x2160+731+0 (normal left inverted right x axis y axis) 597mm x 336mm
   3840x2160     60.00*+  59.94    50.00    30.00    29.97    25.00    23.98  
   1920x1200     59.88  
   1920x1080     60.00    59.94    50.00    23.98  
   1680x1050     59.95  
   1600x1200     60.00  
   1280x1024     75.02    60.02  
   1280x800      59.81  
   1280x720      59.94    50.00  
   1152x864      75.00  
   1024x768      75.03    60.00  
   800x600       75.00    60.32  
   720x576       50.00  
   720x480       59.94  
   640x480       75.00    59.94    59.93  
DP-2 disconnected (normal left inverted right x axis y axis)
DP-3 disconnected (normal left inverted right x axis y axis)
DP-4 disconnected (normal left inverted right x axis y axis)
DP-5 disconnected (normal left inverted right x axis y axis)
USB-C-0 connected primary 5120x2160+0+2160 (normal left inverted right x axis y axis) 800mm x 330mm
   3840x2160     60.00 +  59.94    50.00    29.97    25.00    23.98  
   5120x2160     60.00*   59.94    50.00    50.00    30.00    29.97  
   3440x1440     59.97    49.99    30.00  
   1920x1080     60.00    59.94    50.00    29.97    25.00    23.98  
   1680x1050     59.95  
   1600x1000     59.87  
   1280x1024     60.02  
   1280x960      60.00  
   1280x800      59.81  
   1280x720      60.00    59.94    50.00  
   1152x864      59.96  
   1024x768      60.00  
   800x600       60.32  
   720x480       59.94  
   640x480       59.94    59.93  

I have a similar setup as the OP. My monitors have the same scaling and PPI. image

mmahmoudian commented 2 years ago

huh 🤔 I see a trend here! you both have a smaller monitor above your primary monitor which is aligned to the center. The surprising part is that I couldn't replicate this on my KDE when I moved one of my monitors above my primary monitor.

@Zackhardtoname just out of curiosity, if you change the scale to 100%, do you still face the same issue?

Zackhardtoname commented 2 years ago

I just tested. No.

mmahmoudian commented 2 years ago

Ok then, confirmed. It is about monitor scaling in Linux and perhaps similar thing on Windows.

jordi-sbd commented 1 year ago

Hi guys, I have the same problem with 3 monitors (one of them is the laptop one):

image

and my windows 10 22H2 configuration is:

image

using version for windows (I think the problem is not only in linux):

Flameshot v12.1.0 (96c2c82e) Compiled with Qt 5.15.2 winnt: 10.0.19045 windows: 10

Regards, Jordi

panta82 commented 1 year ago

The fix proposed by @Zackhardtoname works for me

QT_SCREEN_SCALE_FACTORS='' flameshot gui 
BenjaminSchuermann commented 1 year ago

Hi, i have the same Problem with 175% scaling and two monitors. One is UHD and the other on the right is FHD. QT_SCREEN_SCALE_FACTORS='' flameshot gui is solving the problem, but just for the one screenshot if i use my shortcut, everything is shifted again

any workaround for this ?

Zackhardtoname commented 1 year ago

Hi, i have the same Problem with 175% scaling and two monitors. One is UHD and the other on the right is FHD. QT_SCREEN_SCALE_FACTORS='' flameshot gui is solving the problem, but just for the one screenshot if i use my shortcut, everything is shifted again

any workaround for this ?

Yeah I removed the shortcut from flameshot and set a system-wide shortcut to run that command

metalredstar commented 11 months ago

Hi... I experienced the same issue on Windows 10 (laptop 1366x768 primary display with an external secondary 1920x1080 display) but managed to find out the following:

With this screen positioning: image

I get this issue: image

With this other screen positioning: image

everything is ok image

It seems like the overall screen area managed by Flameshot is the sum of the width of both screens the height is the height of the wider display (I think it's because they are extended and positioned horizontally). So when you open the side panel it opens on the extreme left (the 0 value for X dimension which max value is Screen1X+Screen2X), BUT the panel is maximized on the Y dimension so it gets the heigth of the wider display which Flameshot consider de height of it's working area.

You should implement a way to manage irregular areas when extends different sized displays.

Hope this helps

AhmeDseses commented 7 months ago

Salam Alaykum

I found a temporary solution for this.

If it really annoys you and want to fix it, you can just get used to your new screen positions.

The attached image clears the idea.

SS_2024-04-08_05_57_02
DZHEX commented 4 months ago

I have a similar issue. When the configuration is: image the options are off the screen (controls are "above" the monitor), like in the images above, but if it's changed to: image then it's showing up fine.

It's somewhat annoying, that I have the screen I want to shoot on the right monitor (1), but the sidebar is showing up on the far left of the left monitor (2) (in both configurations), which is about a 90..150-degree turn for my head, depending on my pose xD I think the sidebar should stick within the same monitor for less... head-turning, and should select left or right side of the monitor to avoid interfering with the content as much as possible.

That display 3 is some nvidia artifact caused by the VR headset, so I currently can move it wherever I want, since it is not displaying anything, but I do actually have a screen (a TV) that I might want to sometimes display stuff on above the center monitor, so the workaround of "just moving the displays" is a bit of a tough barrier to get over.

...As a side note - I'm also baffled that I require the sidebar to get to the color picker (pippette/dropper) tool... it would make sense as a button next to the actual screenshot area with all the rest of the tools. If I didn't need that sidebar to get to it, I wouldn't have noticed this issue (or the sidebar) whatsoever.