flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.92k stars 1.6k forks source link

Missing Copy/Save buttons #2399

Closed curi0usJack closed 2 years ago

curi0usJack commented 2 years ago

Flameshot Version

11.0.0-4

Installation Type

Linux, MacOS, or Windows Package manager (apt, pacman, eopkg, choco, brew, ...)

Operating System type and version

Arch 5.16.7

Description

Since upgrading to 11, the Copy and Save buttons are now missing when taking a screenshot. I see the checkmark and x buttons, and can double click to copy and save, but I'd prefer the UI options to choose either/or.

Steps to reproduce

  1. Ctrl+Shift+C to start a screenshot
  2. Drag an area
  3. Note the missing buttons.

Screenshots or screen recordings

No response

System Information

i3/xorg

curi0usJack commented 2 years ago

Config

[General]
buttons=@Variant(\0\0\0\x7f\0\0\0\vQList<int>\0\0\0\0\x18\0\0\0\0\0\0\0\x1\0\0\0\x2\0\0\0\x3\0\0\0\x4\0\0\0\x5\0\0\0\x6\0\0\0\x12\0\0\0\x13\0\0\0\xf\0\0\0\x16\0\0\0\a\0\0\0\b\0\0\0\t\0\0\0\x10\0\0\0\n\0\0\0\v\0\0\0\f\0\0\0\r\0\0\0\xe\0\0\0\x11\0\0\0\x14\0\0\0\x15\0\0\0\x17)
contrastOpacity=181
copyPathAfterSave=false
disabledTrayIcon=false
drawColor=#ff0000
drawFontSize=22
drawThickness=2
ignoreUpdateToVersion=11.0.0
savePath=/home/testuser/Pictures/ScreenShots
showStartupLaunchMessage=true
uiColor=#98c379

[Shortcuts]
TYPE_ARROW=A
TYPE_CIRCLE=C
TYPE_CIRCLECOUNT=
TYPE_COMMIT_CURRENT_TOOL=Ctrl+Return
TYPE_COPY=Ctrl+C
TYPE_DELETE_CURRENT_TOOL=Del
TYPE_DRAWER=D
TYPE_EXIT=Ctrl+Q
TYPE_IMAGEUPLOADER=Return
TYPE_MARKER=M
TYPE_MOVESELECTION=Ctrl+M
TYPE_MOVE_DOWN=Down
TYPE_MOVE_LEFT=Left
TYPE_MOVE_RIGHT=Right
TYPE_MOVE_UP=Up
TYPE_OPEN_APP=Ctrl+O
TYPE_PENCIL=P
TYPE_PIN=
TYPE_PIXELATE=B
TYPE_RECTANGLE=R
TYPE_REDO=Ctrl+Shift+Z
TYPE_RESIZE_DOWN=Shift+Down
TYPE_RESIZE_LEFT=Shift+Left
TYPE_RESIZE_RIGHT=Shift+Right
TYPE_RESIZE_UP=Shift+Up
TYPE_SAVE=Ctrl+S
TYPE_SELECTION=S
TYPE_SELECTIONINDICATOR=
TYPE_SELECT_ALL=Ctrl+A
TYPE_TEXT=T
TYPE_TOGGLE_PANEL=Space
TYPE_UNDO=Ctrl+Z
mmahmoudian commented 2 years ago

Let me guess, in your i3 you have bounded your keyboard shortcut to flameshot gui -p. Right? If so, it means you have missed reading the release notes, you have not searched in the existing issues to see if anyone have reported it, and you didn't checkout the pinned issues!

Read this link for more info:

https://flameshot.org/docs/advanced/commandline-options/#final-actions

curi0usJack commented 2 years ago

You seem nice.

I did read the release notes and took note of the new settings such as --clipboard. I also searched existing and closed issues for keywords that I thought appropriate. That said, you did mention something that I looked over, which was my i3 config. As I use a mouse to trigger flameshot, it did not occur to me. Thus good form compels me to thank you for pointing me in the right direction, in spite of your dickishness in doing so.

mmahmoudian commented 2 years ago

@curi0usJack I disagree, being a dick would have been to close this issue, mark it as a duplicate and just post a link. Instead I wrote a polite curse-free text, explained the possible cause, and my hunch, pointed you to a correct direction, marked the issue as "waiting for info" and waited to see if your issue is resolved. In return what did I get? I was called a dick by you! I am nice and I'm trying to stay nice, but everything in life has a limit!

Nonetheless, I apologize for the unfriendly tone of my previous message.

It worth to reiterate that every single day we have multiple users filing bug report and claim that the keyboard shortcut is not working, despite the fact that:

When you filled the form, you were kindly and politely asked to do a little bit of research before filing an issue (screenshot below).

image image


I also searched existing and closed issues for keywords that I thought appropriate.

With all due respect, then let's see what I can find using the words in the title that you yourself chose for your issue.

image

Note that these are just the top N issues as I didn't want to take a long screenshot!

Also check how many posts are in each of those issues. On average it takes 17.33333 posts (and counting) to "solve" each of those, so one person not putting minimal effort in doing a simple search would takes lots and lots of time and energy from everyone. Don't you agree?

All these said, I again apologize for the tone.

Have a good day

curi0usJack commented 2 years ago

Ironically, it would have been more "polite" to simply post a duplicate issue link. I would have followed it and tracked down the issue, commenting if the dupe was correct.

Your reply read as a dunk. If that's what you were going for, congratulations, you got it, and I truly cannot tell if you are just doubling down in your reply. I also see that you list your location as Finland, and if that is presenting a language barrier in the form of nuance, then that may explain it.

Yes, I agree, a "simple search" would have pointed me in the right direction. I performed many such searches, but noticed when I checked just now that I forgot to remove the "issue:open" tag.

image

Additionally, the pinned issue did not strike me as relevant as I didn't know Ctrl - S performed a save function within the selection window until I, ironically, was reading the documentation. That said, it wasn't something that registered with me.

I am going to assume that your follow up reply was genuine, and I appreciate it. I also appreciate using the free tool that is flameshot and appreciate that it is still maintained. I am also a (reasonably) competent linux and github user. I also make mistakes, don't know every single feature of your application, or read every single line of new documentation when a new release drops. All of these things can be true at the same time, and in my case, they are.

Have a good day.