flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.68k stars 1.58k forks source link

Option to load existing image and edit it. #240

Open deragon opened 6 years ago

deragon commented 6 years ago

Flameshot does not allow loading of existing files like Shutter does. It should allow to load an existing image so annotations can be added later, easily. Please add a File / Snapshot - Open - Save - Save as menu.

mbirth commented 6 years ago

Please also let us load from clipboard in case we forgot to mark/blur something.

Migliutin commented 6 years ago

Please add corresponding terminal commands as well, thus allowing to integrate Flameshot within external tools (e.g. clipboard managers).

lupoDharkael commented 6 years ago

I've been secretly working on this feature but it still needs some work. As you can see the CaptureWidget receives a bool "fullscreen" and when you set that value to false it creates an instance in window mode as it is required by this feature request. https://github.com/lupoDharkael/flameshot/blob/415b059fb248eec4b4ee3be85a1594ce99bfce67/src/widgets/capture/capturewidget.cpp#L52

I'm sure the next version of Flameshot will have a mode to use it as an image editor.

RB3rg commented 5 years ago

I can't wait on this; Shutter was removed from Ubuntu 19.04, yeah, I know we can install from 3rd repo but it will be dead soon. Need a replacement urgently. Great tool. Thanks.

kramer65 commented 5 years ago

May I ask whether this feature is still in the works? I'm finding myself needing this almost every week. As a workaround I currently open the image and take a screenshot of the image to annotate it. It works, but it would be great if flameshot could do this.. :-)

infroger commented 5 years ago

Really missing this feature. Shutter still unbeatable because you can easily edit images later.

zaidrpm commented 4 years ago

Any Updates? I am eagerly waiting for this feature. It will be very useful for students making notes on their pc's as flameshot has got best annotation tools on linux. It would be great if you can set option to "darken only" for brush as it is very useful to highlight text.

pierluigiferrari commented 4 years ago

Any updates? I'm also waiting on this feature :)

GrantEdwards commented 4 years ago

I just installed flameshot hoping to use it to annotate some existing image files. I guess I'll have to try shutter, even though it's going to require 50+ other packages be installed as dependencies.

lkrms commented 4 years ago

This will be a great feature when it lands -- Flameshot's annotation tools are basically perfect -- but in the meantime, the best stop-gap I've been able to find is nomacs. Its most recent update includes a "Paint on Image" feature with similar tools, including arrowheads that look the same as Flameshot's.

GrantEdwards commented 4 years ago

Thanks for the pointer to nomacs. It looks like an excellent option as it only requires 2 new libraries instead of shutter's 50+. Now I just have to wait for v3.14 to get into Gentoo Linux. :/

lkrms commented 4 years ago

@GrantEdwards there's always the build from source option :)

GrantEdwards commented 4 years ago

On Gentoo Linux everything is built from source! The latest Gentoo "ebuild" file (which is sort of like a top level "makefile" that includes all of the library dependencies and configuration options along with patches and build script) is for 3.12. I may try updating the ebuild it to build 3.14, but that would only work if 3.14 doesn't require newer versions of libraries than are currently installed.

dindom999 commented 3 years ago

Expecting this great feature!

M1CK431 commented 3 years ago

Hi @borgmanJeremy @lupoDharkael ,

This feature request is open since more than 2 years now.

I could well understand that it's a lot of work to maintain a so great tool and would like to thank you a lot for that :kissing_heart: I guess there is other very important features/bug fix to do too and as myself a developer I perfectly know that no one could be everywhere at the same time.

Still, I'm pretty sure that almost everyone here would be very happy to have a bit more visibility about if and when this feature could be implemented, even in a basic form (like a CLI switch for example)?

Again, keep up the good work, flameshot is (at least one of) the best screenshot tool on Linux, you are amazing guys! :hugs:

borgmanJeremy commented 3 years ago

@M1CK431 We are discussing the best way to actually implement this. There are many corner cases to handle.

Additionally my focus right now is primarily on bug fixes and cleaning up technical debt. The next new feature I want to finish is custom uploaders.

The best way to get this merged more quickly is to help (or inspire others to help) implement this feature. You can join the discussion in our slack group: https://flameshotworkspace.slack.com/

nerdCopter commented 3 years ago

news on this closed issue tracker? closed with or without feature implementation? i understood the "fullscreen" discussion which limits the app to to be unable to edit files. maybe include a separate external executable with similar features? (i.e. "load file icon>execute separate executable to do such.) (maybe the features/functions are in a library making such even easier to implement?)

mmahmoudian commented 3 years ago

@nerdCopter this issue is not closed. Also I couldn't make much sense out of the rest of your comment (perhaps I'm missing a point or reference). Would you please elaborate more on what you are after?

M1CK431 commented 3 years ago

For everyone following this issue, @borgmanJeremy give a bit more details about the "many corner cases to handle" in #1228 :

Opening an existing image is a bit more complicated that it might seem. Since flameshot is always fullscreen and the edits are overlayed on the entire screenshot, we need to figure out what to do with both screenshots smaller than the current screen resolution, and images larger than the current screen resolution.

Perhaps it could be considered as a "news" for @nerdCopter? :hand_over_mouth:

Anyway, as myself waiting for that feature, my suggestions to handle such corner cases are:

just my 2 cents however... :kissing_heart:

nerdCopter commented 3 years ago

modified my comment, fwiw. thank you fellows.
i'm screencapping my screencaps as a workaround :D

shollingsworth commented 2 years ago

For those searching for this, for existing images I found https://github.com/ksnip/ksnip has a lot of the cool annotation features flameshot does.

borgmanJeremy commented 2 years ago

Please keep in mind this is not a forum. This is the flameshot bug tracker. Limit discussion to flameshot bugs or feature requests.

mmahmoudian commented 2 years ago

@venteto don't you think this comment is completely irrelevant to this thread?

venteto commented 2 years ago

@mmahmoudian @nerdCopter I hope you feel better now 🤗

Neboer commented 1 year ago

I think the problem is not as difficult as it seems, the feature request is hard to complete just because it is vague and not clear. Flameshot is, for itself, not an image editor, but a screenshot taker, the operation logic is a lot different between the two kinds of softwares. So if we can change the way to implement this feature to just display a borderless single image pixel-to-pixel on a screen, and keep the four corners' coordinates of the flameshot selection rect the same as these of the displayed image. This way may be simple to implement. Just a little tip for devs as I don't know a lot about how this great software works.

GanerCodes commented 5 months ago

yet again my search queries presents me an open github issue created shortly after the invention of fire

M1CK431 commented 5 months ago

ℹ️ KDE Gwenview now offer that feature so I'm using it as a "flameshot companion" 😉

m10d commented 4 months ago

I think the problem is not as difficult as it seems, the feature request is hard to complete just because it is vague and not clear. Flameshot is, for itself, not an image editor, but a screenshot taker, the operation logic is a lot different between the two kinds of softwares. So if we can change the way to implement this feature to just display a borderless single image pixel-to-pixel on a screen, and keep the four corners' coordinates of the flameshot selection rect the same as these of the displayed image. This way may be simple to implement. Just a little tip for devs as I don't know a lot about how this great software works.

I'd be fine with this.

Related / why this^ might be the "right" part-way approach IMHO: when I use flameshot, I often find myself wishing I could do two things:

  1. zoom in. When I'm annotating a technical/part graphic, or an anatomical picture, being very precise is critical. Both in the placement of arrows, as well as text (over the varied background, getting the text naiiled as to be readable requires a lot of squinting
  2. "finalize" the capture window, then "move" it around - this is essentially same (from the user side at least) as "editing" and image from disc, except it's basically from clipboard. The reason is I capture the image from, say, scholarly paper on monitor 1, then would prefer to do my editing on my graphics tablet w/ pen flat on my desk.

"fully" implementing opening image from file/clipboard would resolve both #1 & #2 use cases. Feature wise, just supporting the loading (From file or clipboard) in the "Full monitor raster" that is (seemingly) what flameshot uses today would (seem to) be all leveragable, and thus just loading the file could logically be shipped today.

stuart938503 commented 3 months ago

I don't have much value to add other than another vote for this feature. Even as an interim, if it were possible to keep the capture window open until I close it/take another screenshot, similar to the Snipping tool in Windows, that would be a big help.

boustanihani commented 3 months ago

I am using ksnip until this feature gets implemented => https://github.com/ksnip/ksnip

GrantEdwards commented 3 months ago

On Thu, Jun 20, 2024 at 11:37 AM boustanihani @.***> wrote:

I am using ksnip until this feature gets implemented => https://github.com/ksnip/ksnip

Yep, me too.