search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.52k stars 1.57k forks source link

Make loading of languages consistent across invocation types #3313

Closed veracioux closed 11 months ago

veracioux commented 1 year ago

Currently, languages are loaded only when invoking flameshot as a daemon, so localization doesn't work for the other invocation types. This fixes that.

veracioux commented 11 months ago

@mmahmoudian Please review it if you can.

mmahmoudian commented 11 months ago

@veracioux It seems something didn't went well. I'm getting the following:

❯  flameshot gui
QLayout: Attempting to add QLayout "" to SidePanelWidget "", which already has a layout
[1]    275691 segmentation fault (core dumped)  flameshot gui

Triggering it from the tray icon works though

mohad12211 commented 11 months ago

@veracioux It seems something didn't went well. I'm getting the following:

❯  flameshot gui
QLayout: Attempting to add QLayout "" to SidePanelWidget "", which already has a layout
[1]    275691 segmentation fault (core dumped)  flameshot gui

Triggering it from the tray icon works though

any news about this crashing issue?

mmahmoudian commented 11 months ago

@mohad12211 unfortunately not resolved yet. Please use clicking on the tray icon which works. This is very high priority and we will resolve it.

marceldev89 commented 11 months ago

@mmahmoudian made a fix for the crash at https://github.com/flameshot-org/flameshot/pull/3370 :)