search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.22k stars 1.55k forks source link

Fix missed escape sequences at /src/CmakeLists.txt #3354

Closed MakarenkoPavel closed 8 months ago

MakarenkoPavel commented 10 months ago

Hello

I found out that when the project repository is cloned to a path containing spaces, it leads to a Cmake configuration error.

The problem occurs only on MacOS

mmahmoudian commented 10 months ago

Thanks for the PR. Looks good to me. Let's wait for another Dev's approval

MakarenkoPavel commented 10 months ago

Hi @mmahmoudian

I also noticed that build instruction is a little bit outdated and may seem to be confusing in some way.

Since root CMakeLists has implicitly specified Qt5_DIR variable on its own we don't need to provide this variable as command line parameter after brew install qt5