search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.22k stars 1.55k forks source link

Appimage #3374

Closed borgmanJeremy closed 9 months ago

borgmanJeremy commented 9 months ago

dang it sorry, wrong upstream again

mmahmoudian commented 9 months ago

Any PR are welcome, especially from you 🤓

May I merge the AppImage fix in Linux-pack.yml?

I also didn't quite understand the macOS change in flameshot.cpp . Is it because you removed imgur and this bit is useless? Because our CI for building macOS works as normal.

borgmanJeremy commented 9 months ago

It’s not quite working yet. I’ll get a clean PR submitted that only affects the app image build once I have it fully working.

yeah that change is only because I fully remove all networking so I may use it on more sensitive pcs.