search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.02k stars 1.53k forks source link

Add shortcut for Grab Color #3387

Open AlexP11223 opened 8 months ago

AlexP11223 commented 8 months ago

Resolves #3384, adds a shortcut (default G) for starting color grabbing.

After finishing it opens the side panel even if it was hidden before. I am not sure if there is a simple way to fix that, but it may be the right way to do it anyway, so that you can see what color was actually grabbed.

mmahmoudian commented 8 months ago

I'm not against the sidebar getting open, but we should gauge user's experience and collect feedback. Regardless, imho this PR in current form is very nice. 👍

Let's let the devs review the PR and then merge.

veracioux commented 7 months ago

@AlexP11223 Thank you for the PR. I have only two small nitpicks:

  1. Please add the shortcut to flameshot.example.ini
  2. Could you change the shortcut description in the GUI to be a bit more verbose, e.g. "Grab a color from the screen"?