flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.02k stars 1.53k forks source link

There is grey spots on MacOs #3424

Open stdakov opened 7 months ago

stdakov commented 7 months ago

Flameshot Version

12.1.0

Installation Type

AppImage

Operating System type and version

MacOS Sonoma 14.1.1

Description

Can not take screenshots of the whole screen

Steps to reproduce

Just run it

Screenshots or screen recordings

image

System Information

MacOS Sonoma 14.1.1

stdakov commented 7 months ago
image
MartinGallauner commented 7 months ago

Same here. Super annoyoing

mmahmoudian commented 7 months ago

@stdakov there quite a few things wrong with this bug report. Would you please clarify/correct them:

  1. Are you sure you are running AppImage in MacOS? Please clarify how you have installed Flameshot
  2. What are those arrows suppose to show? I cannot see any gray spots
  3. Please clarify how you are launching Flameshot. There numerous ways to trigger taking a screenshot: clicking on the systray, CLI, launcher,...

@MartinGallauner would you please also elaborate on the aforementioned points. Thanks.

stdakov commented 7 months ago

@mmahmoudian the screenshot on the ticket is wrong, check the image in my first comment. This is almost a fullscreen screenshot, on the right side and at the bottom you can see these gray parts. The image from the ticket was taken with flameshot , the image in the comment was taken with the default macos screenshot tool. Before I hadn't seen this bug.

mmahmoudian commented 7 months ago

@stdakov you only elaborated on point number two, and even then, I cannot see any gray spots or areas. Please also elaborate on points first and second, and also please draw a box around the gray parts to help us understand what you are really referring to.

mmahmoudian commented 7 months ago

@stdakov do you mean that the lower part of the image is cut?

stdakov commented 7 months ago

@mmahmoudian exactly, the image is cut from the right side and at the bottom 2023-12-02_06-32

DavidCzadilek commented 7 months ago

Was just about to post a more comprehensive ticket but after relaunch of Flameshot (no updates), I can't reproduce the issue anymore. Very strange behaviour.

I've had the same issues as described here happening since macOS update to Sonoma. Flameshot v12.1.0 (96c2c82e) Compiled with Qt 5.15.5 darwin: 23.1.0 osx: 14.1

Device: 16-inch MacBook M2 Pro macOS Sonoma 14.1.1 (23B81)

stdakov commented 6 months ago

@mmahmoudian This happens again, this time only on the external monitor on macOS

ahembree commented 5 months ago

I was also having this issue on an external 4K monitor after the update to Sonoma 14.3 on a 2021 MBP with M1 Pro, but was able to fix it by quitting Flameshot from the top bar and then starting it again, and it appears fixed after a reboot too.

No updates were available for Flameshot when I checked before quitting the application.

Update: issue came back, nothing changed except for the system going to sleep

mmahmoudian commented 5 months ago

I don't have macOS and Apple hardware to reproduce this, but I can give you one tip which based on the comments I read might explain this issue:

Flameshot is not informed when you add monitors or change resolution. So if Flameshot is already running in the background and something like adding external monitor happens, Flameshot will still have the previous settings in mind. So the trick would be to Quit Flamshot and start it again.

This is of course a "bug", but not really. There is no way that OS inform Flameshot about these changes, but we can perhaps read these settings when the user wants to take a screenshot. The downside of doing this is that querying such thing would add to the delay between when you trigger the command, and when the screenshot is taken. We can also alternatively read such settings every 30 seconds or so, but that would cause two issues: 1) your computer do some extra process every 30 seconds, and 2) bug tracking will be inconsistent because if a user connect an external monitor and during these 30 seconds trigger the screenshot, Flameshot has not updated the settings and they will have an issue.

Perhaps one ideal way is to have some sort of automation in macOS that triggers a simple script upon monitor changes, perhaps Automator can do this? ¯_(ツ)_/¯ and that script can be as simple as pkill flameshot ; sleep 0.5s && flameshot &