search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.02k stars 1.53k forks source link

screenshots are discolored [Wayland, KDE] #3429

Closed lastendcondctor closed 6 months ago

lastendcondctor commented 7 months ago

Flameshot Version

Flameshot v12.1.0 (3d21e496) Compiled with Qt 5.15.11

Installation Type

User repository (AUR)

Operating System type and version

Arch Linux

Description

noticed a trend of flameshot on wayland not properly using the same colors, same issue as described here. can confirm it definitely wasnt a problem on x11. originally considered it an issue with how the opacity outside area selection layer was applied but there's no difference in color whether its at 0% or 100%.

Steps to reproduce

  1. run any screenshot command
  2. select region in the blank space of a chat app (as example)
  3. paste said image in the chat of same chat app
  4. notice difference in color between image and background color of chat app when there shouldn't be any

Screenshots or screen recordings

video preview https://github.com/flameshot-org/flameshot/assets/80832006/606529f4-16c7-428f-99f6-31a575ce49af
image taken from video preview ![image](https://github.com/flameshot-org/flameshot/assets/80832006/a1d9ef8a-60cd-46c9-ab20-973ec8c1264f)
image taken in x11 with the same app theme ![image](https://github.com/flameshot-org/flameshot/assets/80832006/69ed856b-fe41-4e84-a222-1d075cf4857f)
images merged for quick comparison ![image](https://github.com/flameshot-org/flameshot/assets/80832006/327f7ec2-b37b-4683-962a-3ebd3eb831bb)

System Information

inxi ``` System: Host: pudding Kernel: 6.6.4-arch1-1 arch: x86_64 bits: 64 Desktop: KDE Plasma v: 5.90.0 Distro: Arch Linux Graphics: Device-1: Intel DG2 [Arc A770] driver: i915 v: kernel Display: wayland server: X.org v: 1.21.1.9 with: Xwayland v: 23.2.2 compositor: kwin_wayland driver: X: loaded: modesetting dri: iris gpu: i915 resolution: 1: 1920x1080~165Hz 2: 1920x1080~144Hz API: EGL v: 1.5 drivers: iris,swrast platforms: wayland,x11,surfaceless,device API: OpenGL v: 4.6 compat-v: 4.5 vendor: intel v: N/A renderer: Mesa Intel Arc A770 Graphics (DG2) ```
display configuration ![image](https://github.com/flameshot-org/flameshot/assets/80832006/8e519d67-6cc5-40b7-a655-036f6a57b83e)
lastendcondctor commented 7 months ago

some additional information i wanted to add after sleeping over it:

  1. while i'm currently using the plasma 6 beta, this was also an issue on plasma 5 stable
  2. while i was doing my opacity testing i noticed that the filter gets applied at the moment of capture - setting it to 0% and spamming a capture key (and cancelling it) a couple times in a row makes it very easy to see the discoloring
  3. since flameshot on wayland still has some issues w/ multi-screen setups, i'm using a kwin window rule to be able to capture in the first place - this should be the one mentioned here
  4. the shortcut i use is mkdir ~/Pictures/screenshots/`date +"%%Y-%%m"` | flameshot gui -p ~/Pictures/screenshots/`date +"%%Y-%%m"` --accept-on-select --clipboard - the issue also occurs on regular flameshot gui however
lastendcondctor commented 6 months ago

downgraded to plasma 5 to fix arch packaging related issues with qt and i can't reproduce the bug anymore, will mark as solved until i come across it again