search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
23.96k stars 1.52k forks source link

config option to disable grim warrning #3456

Closed Monirzadeh closed 3 days ago

Monirzadeh commented 6 months ago

This PR attempts to fix annoying notification about Grim close #3186 @mmahmoudian Should I add anything else? or any opinions?

Monirzadeh commented 2 months ago

@mmahmoudian can you please review this one?

mmahmoudian commented 2 months ago

Thanks for the PR. As an internal policy, I generally refrain from merging code changes before it is also approved by other devs. I asked other devs to review this issue on our Matrix channel (which you are also welcome to join). I will also tag them here to increase visibility:

@veracioux @panpuchkov @jack9603301

b0ch3nski commented 2 weeks ago

There is a typo across all the code: Warnning -> Warning

Monirzadeh commented 1 week ago

Thanks @b0ch3nski i fix that.

mmahmoudian commented 4 days ago

@Monirzadeh thanks for the PR. Would you please handle the clang format. I'll merge when that passes. 👍

clang-format -i $(git ls-files "*.cpp" "*.h")

Source: https://github.com/flameshot-org/flameshot/blob/master/docs/CONTRIBUTING.md#code

mmahmoudian commented 3 days ago

@Monirzadeh thanks for the PR and clean code. @jack9603301 thanks for the code review.