search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.69k stars 1.58k forks source link

Add new option where arrow can be drawn in a reveresed way #3477

Open lvhungdev opened 8 months ago

lvhungdev commented 8 months ago

This PR attempts to fix #2144 where arrow can be drawn in a reversed way. The head will be drawn first, the tail later. This behavior can be toggled via configuration.

reversed-arrow

https://github.com/flameshot-org/flameshot/assets/47495076/0582b2ac-5662-402c-95cd-47f3c752c77e

lvhungdev commented 5 months ago

Hi. This PR has been sitting for a while without any updates. Am I missing something to get this PR reviewed?

UnkwUsr commented 5 months ago

Throwing random proposal for discussion:

Maybe it can toggle between default state by holding some key modifier, like alt or ctrl (instead of checkbox in settings) (but yes, then it is harder to find out about this feature even exists)?

mmahmoudian commented 5 months ago

@lvhungdev Thanks for the PR. We are waiting for this PR to be approved. I generally support the idea and the PR but conventionally I will not attempt to merge code changes without approval of our C++ devs.

While we are here, would it be possible for you to add the Alt to toggle this on the fly? i mean whatever the setting/config is, the Alt flips the direction as long as Alt is pressed?

@UnkwUsr Thank you for the suggestion. I appreciate your input. I just want to point out that Ctrl is already is use. while drawing an arrow or line, holding Ctrl would snap the arrow to 45 degree angles. I believe the Alt is a better choice as also it "alters" the behavior :)