Line and text size - Githubissues

kramer65 commented 6 years ago

Currently the lines are really thin and the text small. Is it possible to have some kind of slider to increase the size? Monosnap has a slider which works great. Maybe you can get some inspiration from that.

hosiet commented 6 years ago

@kramer65 Just out of curiosity, is there any circumstances where mouse is not available so you cannot adjust text size / line width?

If yes, we may should implement such feature on the UI, for example in the sidebar.

Rmano commented 6 years ago

Maybe the OP did not notice the fact that the scroll wheel change line / text size... Still, I never tried to use it with a touchpad (especially the **** ones with just two keys). Tomorrow I'll try.

kramer65 commented 5 years ago

@hosiet - As @Rmano suggested I indeed didn't realise that scrolling would change text size. I'm never using a mouse, but always on touchpad (working on a Purism Librem 13). It works ok-ish with the double scroll touchpad (not really predictable, it took me a minute to get it to the size I wanted) but since it remembers the size I'm all good now.

As a suggestion; if people have never changed the size you could maybe display a hint: "Try scrolling to adjust the size of the lines/arrows/text". That would have prevented me from creating this issue, and maybe helps others getting more use out of Flameshot.

Anyway. This has again increased the awesomeness of Flameshot for me!

hosiet commented 5 years ago

@kramer65 That exact hint appears every time you are making a screenshot. So you are always missing it? That's a pity :-(

kramer65 commented 5 years ago

@hosiet Wow, that was stupid. I never actually read that.. :disappointed:

I guess I never read it because it doesn't look very appealing. I looks like one of those disclaimer or credential texts.

Now I read it, I just found the space bar as well. :smile:

Maybe add some symbols or screenshots to that part. For me that would make it something I would easier look at.

Anyway, thanks!

micmania1 commented 5 years ago

I'm in the same boat as @kramer65.

As well as being really easy to skip over, the message for me was on a different screen to the one I was taking a screenshot of. Even when I read this ticket it took me a second to find that message as I wasn't really paying attention to that screen.

On a sidenote, now that I know it exists it works great :)

alexfornuto commented 4 years ago

I was also unaware of this functionality, and found this as the first documentation of a solution to changing line width. I suggest you add it to the project site's documentation.

Rmano commented 4 years ago

The only thing I would change is to have separate counters for line width, text size, etc. Now if you change text size and then select the line you have a different line width from before... it's surprising the first time, and I think a bit unexpected.

ghost commented 3 years ago

Wow. I had never read that message until now. I've only ever read the first line which tells you how to select an area or escape. I would suggest aligning the text to the left and adding bullet points or more space between the lines to make it more appealing to read.

pmontrasio commented 3 years ago

Luckily this is the first result for "flameshot font size". I'm commenting to add some insight for future work on the UX, if anybody feels like doing it. I also probably never read all the hint text after years of using Flameshot :-) If I did, I forgot about it, even about pressing Return to take the screenshot. I always click on the "Save the capture" button. I expected to be able to (in order of least surprise): 1. set the font size in the configuration or 2. drag some box around the text to resize it. By the way, I never use a mouse, only the touchpad of my laptop. I confirm that two finger scrolling changes the size of text and lines.

pguedes commented 3 years ago

+1 for touchpad (not very precise selecting size) and not reading the tip (also +1 for mb doing something for it to attract more attention)

also... great tool this is!

mmahmoudian commented 3 years ago

@pguedes with #1426 there will be buttons added to increase the size. I think you can map it to your custom key binding (e.g Ctrl++ and Ctrl+-

You can see an old screenshot of this feature here: https://github.com/flameshot-org/flameshot/pull/1131#issuecomment-720216151

turboBasic commented 3 years ago

I am trying to figure out how to change line width / font size with touchpad on Ubuntu 20 - without any success. Two-finger scrolling is turned on in Ubuntu's Mouse and Touchpad settings and is working as expected in other applications but when I am trying to two-finger-scroll while taking a screenshot and marking areas / typing text in Flameshot - it does not change line thickness and font size. Switching Two-finger scrolling / Edge scrolling in Ubuntu Mouse and Touchpad settings does not help either.

Leaving here a workaround: press SPACE in screenshot-taking mode and change thickness by dragging Active thickness element's thumb. Active thickness settings affect both line width and text size

PS: Flameshot v0.8.5-4. 💚 for Flameshot

mmahmoudian commented 3 years ago

@turboBasic there has been some attempts to implement Ctrl++ to change sizes. I don't know the current state though. Perhaps @borgmanJeremy can tell you more if there has been any progress in that direction.

Talk2Giuseppe commented 2 years ago

Maybe the OP did not notice the fact that the scroll wheel change line / text size...

Been using the app for years and NEVER knew that! My arrows got super fat and I had no idea what happened and couldn't find a place that would fix it. I actually started to search for new screenshot program! Thanks for the tip!

mmahmoudian commented 2 years ago

@Talk2Giuseppe

Been using the app for years and NEVER knew that!

Every user gets this message every single time the open Flameshot (unless they have turned it off in their config):

couldn't find a place that would fix it. I actually started to search for new screenshot program!

You could simply ask or even if it is a bug, report it.

pmontrasio commented 2 years ago

I add to my reply of Feb 22, 2021. After a year and a half I forgot again about that message. I see it each time I take a screenshot and I never really see it. I remember how to change the line width now but the other shortcuts surprised me again (enter instead of click, ctrl s to save, etc.) We users read those message once, don't remember everything, forget all of it. I (a developer) refrain from adding them to the software I develop unless a customer really really wants them.

Settings like line width should go into a configuration screen or into a line width/color button. The UI of the edit screenshots apps I use on my phones and tablet manage to make those settings discoverable.

On September 4, 2022 12:58:44 PM GMT+02:00, Mehrad Mahmoudian @.> wrote: @.

Been using the app for years and NEVER knew that!

Every user gets this message every single time the open Flameshot (unless they have turned it off in their config:

-- Reply to this email directly or view it on GitHub: https://github.com/flameshot-org/flameshot/issues/351#issuecomment-1236311607 You are receiving this because you commented.

Message ID: @.***>

mmahmoudian commented 2 years ago

@pmontrasio

I see it each time I take a screenshot and I never really see it. I remember how to change the line width now but the other shortcuts surprised me again (enter instead of click, ctrl s to save, etc.) We users read those message once, don't remember everything, forget all of it. I (a developer) refrain from adding them to the software I develop unless a customer really really wants them.

You as a developer should be well aware of the fact that in absolute majority of GUI software Ctrl+s is used for "save", Ctrl+a is used for "select all", Ctrl+c is used for "copy to clipboard", so I'm surprised that you are surprised! 🙂 But if you don't like them, you can change them in the settings according to your preference, either from the Configuration window, or by changing the config file.

On top of this, user gets the popup message I mentioned before literally every single time (and for those who wonder, yes, it is dynamically generated, so if you change a keybinding, it shows the correct keybinding to the user)

Even if the popup message is dismissed, hovering mouse on buttons (if user have not deliberately hide them) shows the keybindings:

In addition to all these, all the default keybindings are also listed on our website:

https://flameshot.org/docs/guide/key-bindings/

Settings like line width should go into a configuration screen or into a line width/color button.

No. The line width is something that is very very frequently used, therefore it should not be buried in the configurations. Actually it is so much used that we have 4 different ways to change it:

mouse wheel (before, during, and even after you have drawn something)
from the sidebar (open it with Space):
after selecting a tool, just start typing the number and you will see the new size in a bubble at the top left of your screen
Please read the response to the next quote 🤓

The UI of the edit screenshots apps I use on my phones and tablet manage to make those settings discoverable.

Those are touch screen devices, their software have to be designed in a slightly different way since typically there is no keyboard or mouse available for interacting with the device. But even then, for touch screens we have added two buttons (disabled by default) that the user can activate and use on their touch-screen device and change the size

That said, you can of course still use the slider in the sidebar to change the size, which is similar to how android screenshot annotation tool does it.

I hope these detailed explanation have helped you use Flameshot more efficiently. If you have further question/concerns, please feel free to either open an issue or open a discussion.

Cheers,

flameshot-org / flameshot

Line and text size #351

Please read the response to the next quote 🤓