search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
23.92k stars 1.52k forks source link

Update Windows-pack.yml: update dependencies #3586

Closed Saibamen closed 1 month ago

Saibamen commented 2 months ago

Should speedup artifacts upload: https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/

Fix deprecated warnings

mmahmoudian commented 2 months ago

@Saibamen Thanks, I was also in the process of updating these. there is one caveat: the actions/upload-artifact from v3 to v4 has some breaking changes and is advised to go through the migration documentation:

https://github.com/actions/upload-artifact/blob/main/docs/MIGRATION.md

Have you already confirmed the update works without breaking the CI? (I haven't so I'm asking to be sure and also save some time) 😃

Saibamen commented 2 months ago

You need to approve CI to run in my PR

image

https://docs.github.com/en/actions/managing-workflow-runs/approving-workflow-runs-from-public-forks

mmahmoudian commented 2 months ago

It seems we need to go through migration documentation as they failed in artifact upload part

Saibamen commented 1 month ago

Please run CI again

Saibamen commented 1 month ago

Ready for review

mmahmoudian commented 1 month ago

@Saibamen Thanks for your persistence and your contribution. I believe now the CI should work based on the migration docs. Let's see in a couple of minutes when the Actions are finished and see if we get any hiccups or errors. If not, I will merge it. Thanks again :+1:

Saibamen commented 1 month ago

Packaging(Linux) / Build deb on debian-10 armhf (pull_request) has timeout

mmahmoudian commented 1 month ago

@Saibamen Thanks for your persistence, patience, and contribution