search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
23.92k stars 1.52k forks source link

Fix update cis #3587

Open mmahmoudian opened 2 months ago

mmahmoudian commented 2 months ago

I've updated everything to the latest minor or major version depending on if they have their major version tag following their latest stable minor version tag or not.

I have kept the actions/upload-artifact back in v3 because:

  1. It seems there are breaking changes between v3 -> v4 (more info)
  2. there is a PR (#3586) that have tried to update this for the Windows CI, so I would not change it to avoid duplicate and confusion
mmahmoudian commented 2 months ago

@Saibamen It is not clear in the Github documentation if there is a difference between @v4 and @v4.3.2. Bascially if @v4 means 4.0.0 tag or 4 tag, or latest of 4.x.x tags.

In some workflows, they move their major version tag to the latest minor version (e.g v1 always updated to the latest of v1.x.x: https://github.com/snapcore/action-build/tags ), but this does not happen in all workflows (e.g. https://github.com/jurplel/install-qt-action/tags )

Do you know how for example the @v4 is handled by Github Actions?

Saibamen commented 1 month ago

You can use https://github.com/saadmk11/github-actions-version-updater