search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
23.92k stars 1.52k forks source link

Disable grim's png compression #3612

Open MaeIsBad opened 1 month ago

MaeIsBad commented 1 month ago

Grim by default used level 6 for compressing PDFs, which could take as long as a second depending on the hardware. This caused a big delay when taking a screenshot with grim, leading to a bad user experience. This commit sets the compression level to 0(uncompressed) radically speeding up the process of taking a screenshot(down to just a few ms on my machine).

mmahmoudian commented 1 month ago

I'm not sure how I feel about this. On one hand you are right that it speeds up the process, on the other hand it will result in much larger PNGs (benchmarking is needed to assess how large). Perhaps a better way is to allow the user to adjust this value, potentially via a slider.

Also, before you wonder, I generally don't merge code changes unless is approved my one of the devs. As for this PR, perhaps we should wait for opinion of other devs too.

Thanks again for this PR.

MaeIsBad commented 1 month ago

I'm not sure how I feel about this. On one hand you are right that it speeds up the process, on the other hand it will result in much larger PNGs (benchmarking is needed to assess how large). Perhaps a better way is to allow the user to adjust this value, potentially via a slider.

This is not an issue. Flameshot recompresses the image on it's own when saving the image regardless, meaning this change doesn't impact the final file size