search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
23.92k stars 1.52k forks source link

fix: workaround macos fullscreen animation #3625

Open paperdave opened 3 weeks ago

paperdave commented 3 weeks ago

This would resolve #2886 at the cost of the system menu bar not being able to be visible as part of the capture window.

image

If there is something available in QT to put the window above the menu bar or disable the animation, we should use that instead. I couldn't find an API to do that though -- I feel like i0t has to be possible somehow, since the built-in screenshot command does not have this issue, and System Settings is able to draw overlays that are placed on top of the menu bar (if you have multiple monitors and re-arrange them, a red border surrounds the screen); Maybe this API is reserved for the system apps?

For now, I find this trade off reasonable as the fullscreen exit animation as shown in the issue is incredibly annoying, and most screenshots do not need to annotate the menu bar (you can still screenshot it, but the system bar is in the way for annotations).

mmahmoudian commented 3 weeks ago

Do I understand it correctly that this PR makes Flameshot to be a "maximized" window but not a full-screen one?

Untersander commented 2 weeks ago

I believe this would also fix the issue from #2612 as not capturing the menu bar, for me it would be worth to lose the feature to capture the menu bar but if anybody has a solution how this could be fixed without losing this feature would be nice.

ElijahLynn commented 2 weeks ago

Thanks for the initiative!

I would like to suggestions from the community on what other OSS screenshot tooling is there that does this correctly? Maybe then we could see what API or techniques they use.