search

flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.56k stars 1.57k forks source link

Setting to always save as JPG #496

Closed erikdubois closed 3 years ago

erikdubois commented 5 years ago

Is it already possible to set flameshot to always save as JPG rather than PNG.

JPG is much better for websites than PNG regarding the size of the file.

Neyromancer commented 5 years ago

Hi i am new here but if it is needed i can try to do this. It seems it is possible to implement by rewriting a bit code in screenshotsaver.cpp

vimpostor commented 5 years ago

JPG is literally the worst lossy image format, you need to let it die already. If you do need a lossy format, use something like BPG (or any other modern lossy format) instead.

erikdubois commented 5 years ago

I do not care about that. I need an image that is low in KB for the website. I want a fast loading webpage.

vimpostor commented 5 years ago

That's literally, what I was talking about.

A BPG file has about half the size compared to a JPG file of equal quality.

Jacalz commented 5 years ago

I think this along with the other supported formats should have an option in the configuration tool where you can set the default format, not just for JPEG.

erikdubois commented 5 years ago

Any prospect on the development to have the possibility to save as jpg.

AlexP11223 commented 5 years ago

JPG is much better for websites than PNG regarding the size of the file.

it depends on the content, sometimes png has smaller size.

arcolinuxz commented 4 years ago

Has anything been done about this question? Can we / will we be able to save as jgp? If it is never gonna be on the agenda, please tell us and close the issue.

AlexP11223 commented 4 years ago

@arcolinuxz it's a relatively small open source project, the best way to make something happen is to implement it yourself and send PR.

jam-2000 commented 4 years ago

Hi i am new here but if it is needed i can try to do this. It seems it is possible to implement by rewriting a bit code in screenshotsaver.cpp

@Neyromancer It will be awesome!!! A lot people need JPG very much!

erikdubois commented 4 years ago

Follow up post - is there any development going on on this subject?

th317erd commented 4 years ago

It wouldn't be hard to setup a watcher script that would watch the folder flameshot saves to and automatically generate a JPG for every PNG in the folder...

blaueente commented 4 years ago

Don't forget the use case with ->clipboard->chat; there, the quality loss is not important at all, but nobody wants to wait for 5MB to be transmitted.

navigante commented 4 years ago

Yes, lossy compression format would be strongly appreciated ...

kirjeldus commented 4 years ago

Don't forget the use case with ->clipboard->chat; there, the quality loss is not important at all, but nobody wants to wait for 5MB to be transmitted.

Bump. This is one of my primary uses of this software. Format/compression settings for clipboard copy would save many many mb!

th317erd commented 4 years ago

I must admit I am with the developers on this one. Though I have also wished at times that JPEG was supported (for whatever various platform I am using that still lives in the dark ages and doesn't support PNG) I think JPEG is a terrible format, especially for this type of thing.

It is not at all hard for anyone of you (with a little Googling) to do one of two things (or both):

  1. Make a watcher script that will automatically convert the PNG files to JPEG
  2. Make a watcher script that will automatically convert the clipboard into a compressed format

Both of those would likely take a seasoned developer a day or less, and would be a fun week long project for someone who isn't even familiar with coding. Go get NodeJS, find the correct modules needed to achieve this, and git r' done. Then post your work here so other people can use it.

Or, even better, add the functionality here to Flameshot via a PR, and then maybe the developers will be happy to accept work done instead of empty (and admittedly pointless) requests.

The world is changing people. JPEG is slowly dying, and just like MP3 should never have been a mainstream format anyhow. At some point we really all do need to move away from the dark ages and embrace the light of change...

AlexP11223 commented 4 years ago

Or, even better, add the functionality here to Flameshot via a PR, and then maybe the developers will be happy to accept work done instead of empty (and admittedly pointless) requests.

I submitted my PRs in October and they are still not merged...

Also there were no releases for even longer time, so it may be difficult for many users to get the up-to-date version even if it gets merged.

would save many many mb!

Probably not if you are not screenshotting something like photos/movies/some games. In some cases JPG can even take more space.

michaelskyba commented 4 years ago

JPG is literally the worst lossy image format, you need to let it die already. If you do need a lossy format, use something like BPG (or any other modern lossy format) instead.

@magnus-gross

How can you save a screenshot as a .bpg? Typing in ".bpg" at the end of the screenshot name just saved it as "name.bpg.png"

borgmanJeremy commented 4 years ago

The version on the main branch now supports jpeg saving. This will be released as 0.8 in about 1 week. Is there more to this request other than supporting jpeg?

blaueente commented 4 years ago

My ideal implementation would make it possible to set "JPEG" as default for clipboard (the "IT-Support"-via-Chat quick&dirty solution), and "PNG" for saving (the: "I-bother-opening-it-from-pictures-folder")

borgmanJeremy commented 3 years ago

@mmahmoudian @hosiet @ZetaoYang

Any concerns with adding an option to change the clipboard to jpeg? I would have it off by default.

mmahmoudian commented 3 years ago

I think PNG should be the default as the JPEG image compression might screw up the quality and we get bug reports.

But I agree that having the option is good.

hosiet commented 3 years ago

Having JPEG is okay but I'd like to see it turned off everywhere unless the user has changed the settings.

borgmanJeremy commented 3 years ago

This is how i was thinking off adding it: image

mmahmoudian commented 3 years ago

would it be possible to define the default format in a dropdown menu. Default for clipboard, saving, uploading,...

borgmanJeremy commented 3 years ago

Could so something like this: and then use whatever is selected as the default for all 3 of those items:

image

hosiet commented 3 years ago

Maybe not piling up the "General" tab. What about opening another new tab specifically handling the Image Output? We can move all related setting into the new tab.

borgmanJeremy commented 3 years ago

@hosiet that sounds good to me, then we could allow a different default for clipboard, saving, and imgur which I think better solves the problems outlined in this discussion.

andrehtgti2 commented 3 years ago

Up !

test-account-0 commented 3 years ago

I would like TIFF format without any compression.

borgmanJeremy commented 3 years ago

Version 0.9 now supports jpeg on clipboard. Going to leave this open because I think there is still more work to be done to customize the format for uploads / saves.

adamjacobmuller commented 3 years ago

@borgmanJeremy where does the option to select the filetype for the clipboard live? I'm on MacOS and images come onto my clipboard as tiff which is... not great.

borgmanJeremy commented 3 years ago

@AdamJacobMuller Around here: https://github.com/flameshot-org/flameshot/blob/71d595fbcea3eac9d1aaa51f42cb53935bd9f3a7/src/utils/screenshotsaver.cpp#L43

mmahmoudian commented 3 years ago

@borgmanJeremy

Version 0.9 now supports jpeg on clipboard. Going to leave this open because I think there is still more work to be done to customize the format for uploads / saves.

Can this issue be closed as #1790 is merged?