flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.67k stars 1.58k forks source link

Add option to set quality of screenshot #506

Open Jacalz opened 5 years ago

Jacalz commented 5 years ago

Right now we get what looks like quite hard compressed images which get small in size but they don’t look all that good. It would be great to have a slider where you can set the compression strength and possible choose to don’t compress the images.

Mershl commented 5 years ago

Flameshot is using the screenshot interface of the respective WindowManager you're using (see src/utils/screengrabber.cpp).

Based on the screenshot interface of Gnome I don't see an option to improve the quality (org.gnome.Shell.Screenshot).

Gnome's onboard screenshot tool is suffering of the same compression artifacts.

Jacalz commented 5 years ago

Weird. I thought Gnome Screenshots gave higher quality screenshots, but it cool to get more understanding of how the software works. Thank you :+1:

ganomi46 commented 5 years ago

I have got also picture quality issue in KDE Debian. It would be great if we can set picture quality.

crimsonskyrem commented 5 years ago

I got this issue, too my screenshot image quality was very low that make it too hard to see then I found that's because I deleted the default gnome-screenshot after I reinstalled the gnome-screenshot, the image quality was good to see

thecodemonk commented 4 years ago

I don't know as if this is correct.. I'm on Pop OS and my screenshots with the built in gnome screenshot are WAY better quality than Flameshot. I found this issue after searching on how to fix it. The screenshots with Flameshot are compressed way more than the built in gnome-screenshot.

pymen commented 4 years ago

still actual!

Martin-Eckleben commented 4 years ago

Recently someone mentioned KDE < 5.19 + Wayland will compress screenshots as well. Ill look into this but it will probably take some time because this repo has a lot to catch up to.

pymen commented 4 years ago

Looks like quality can be set via https://doc.qt.io/qt-5/qpixmap.html (i am not a c dev)

borgmanJeremy commented 4 years ago

@pymen What screen resolution do you have? I am looking to reproduce the issue.

pymen commented 4 years ago

@pymen What screen resolution do you have? I am looking to reproduce the issue.

I do not have an issue, I just wanted to say that it will be nice to have some configuration to set the quality of the capture image, for example, if I need to post IMG to slack I do not need quality=10, 3 will be enough

borgmanJeremy commented 4 years ago

Ohh ok, I was looking into an issue where people are saying Flameshot is compressing the image when they do not want it to.

dcfreire commented 3 years ago

This option would be really good. I'm using AwesomeWm with Plasma and the compression is really apparent.

dotarjun commented 2 years ago

Facing the same issue. Any fix found yet?

mmahmoudian commented 2 years ago

@RJN-bot what version if Flameshot are you using? In general PNG is a lossless compressed image format and you should not see any quality issues with PNG. So make sure you are saving as PNG and not JPEG.

YSCohen commented 2 years ago

I also have this problem. I'm using scoop-installed Flameshot on Windows 10. As you can see, the below image is very blurry. It has the same resolution as a similar shot taken with win+shift+s image

hubyhuby commented 1 year ago

Please include WEBP format . It is a very good open image format for the web.

mauromotion commented 1 year ago

How is this closed?

I'm using Flameshot on Arch with i3. I want to use the JPG compression but I need to be able to set the compression level like in 99.999% of other screenshot software out there. If different file formats exist there are several reasons, so don't just tell people "use PNG". If someone needs to use JPG they also usually need to be able to set its compression (the main feature of the JPG is indeed image compression while PNG's isn't). Please don't let me get back to scrot...at least set the default JPG quality to a higher level, as it's not very usable right now (try to get a screenshot of some text and you'll see). Thanks.

mmahmoudian commented 1 year ago

@mauromotion you wrote two points and here is the answer:

  1. About this issue being closed: please pay attention before pointing fingers

aa

  1. If you want lossless, don't use a lossy format. That simple. You are free to choose whatever software you want, but the reality is that JPEG is a lossy method by design. It meant to be lossy.
mauromotion commented 1 year ago

Yeah my fault for not noticing it was still open. I'm still new to GitHub.

But still, it's very limiting not being able to select the level of compression of a lossy format. Who's deciding for me? And on what basis?

All I can see is that whoever decided took a wrong choice because if I take a screenshot with Flameshot as a JPG the resulting image is unusable, forcing me to choose another file format. Why do I have to use a much larger PNG file when I know for a fact that if I could set the compression level of the JPG it would be just fine? Not being able to set the compression level of a JPG file completely hinders the usage of a JPG file format, IMO.

PoneyClairDeLune commented 4 months ago

Would be delighted to see Flameshot offering WebP (q & psnr) and JPEG XL (d) support with quality controls.