flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.96k stars 1.6k forks source link

Make the selection cross more visible #863

Open Porrumentzio opened 4 years ago

Porrumentzio commented 4 years ago

Sometimes is very hard to find out where the selection cross is due to its thinness and unique color.

So my proposal is simple: add an external white border to the cross; this way the cross will be seen in better in dark background and also good if the background transparency is very low¹, because the inner dark part of the cross would remain there.

¹ Many users use this as workaround to this problem: to be able to see the cross/cursor.

SkoricIT commented 3 years ago

This seems to happen on dark system theme especially. For me the cursor is dark on dark background when using Manjaro with XFCE and Adwaita Dark with Breeze Mouse theme. Changing to bright mouse theme (Breeze Snow) and restarting does help as the cursor is now white.

Maybe the overlay color should be configurable or the cursor color should be forced?

Edit: This seems to mostly be a problem from Breeze and fixed overlay color: grafik This is almost exactly how the cursor looks for me and why i can't find it when starting a selection.

Porrumentzio commented 3 years ago

Happens same here on Manjaro MATE, with Breeze dark mouse theme. Making the mouse-theme white also is a workaround for me.

Seems that the contrast colors are bad for dark themes. It should be same as for white theme.

FredOWalles commented 3 years ago

Since it seems a general icon readability issue, a rework of this particular cursor icon could be requested at an other place (manjaro or xfce? - not sure where the exact responsibility sits).

Most easiest solution though would be to get the cursor option like: system, contrast, [one more maybe]

Porrumentzio commented 3 years ago

This is KDE's Breeze issue. I don't know how to report this very well, so if someone else does, better: https://bugs.kde.org/

FredOWalles commented 3 years ago

There seems to be an updated/customized Breeze cursor set: by KDE VDG which solves the issue. (compare crosshair with previous post)

2021-05-21_17-54