flameshot-org / flameshot

Powerful yet simple to use screenshot software :desktop_computer: :camera_flash:
https://flameshot.org
GNU General Public License v3.0
24.8k stars 1.59k forks source link

Improve contrast in circle counter tool #978

Closed hosiet closed 4 years ago

hosiet commented 4 years ago

This is a follow-up and improvement for #941 and #944 .

v0.8.1 provided an initial fix to the font color issue of v0.8.0 (choosing black/white font according to the color of circle tool). The current implementation is to set a threshold on the Lightness in HSL color space (threshold=75). However, this does not work well with some colors like dark blue:

图片

Like the one in the image above, No.2 should use a white number instead of a black number.


It's a classic problem with many discussions before. What I found:

chux0519 commented 4 years ago

Hi I've done this using the algorithm in first link you provide. And it looks better.