flamewave000 / dragonflagon-fvtt

DragonFlagon FoundryVTT Modules
BSD 3-Clause "New" or "Revised" License
64 stars 59 forks source link

DF User Logger: Conflict with automated-jb2a-animations #114

Closed Merudo closed 3 years ago

Merudo commented 3 years ago

Conflicting Module(s)

Describe the conflict When a user logs in and automated-jb2a-animations is enabled, an error is thrown into the console

Expected behavior No error in the console from a user logging in.

Screenshots image

Additional context (Optional) An error report to automated animation https://github.com/otigon/automated-jb2a-animations/issues/46 has been filled, but @otigon claims the bug is entirely due to DF User Logger.

flamewave000 commented 3 years ago

Not to step on any toes, but the exception is being thrown in their module, not User Logger. All my mod is doing is calling ChatMessage.create() just like everything else does. It also is a Whisper and flagged as OOC. No reason to assume it is something that should be animated. They're literally simple messages being posted to the Chat.

Per the mod's own description:

Automated Animations reads the data passed through Chat Cards...

This tells me they are parsing all the messages and "thinking" a message from User Logger is somehow important and needs to be animated. This is likely due to not handling special characters, or doing pattern matching that is too broad. Literally nothing I can do, the ball is entirely in their court to improve their message processing code.