flamewave000 / dragonflagon-fvtt

DragonFlagon FoundryVTT Modules
BSD 3-Clause "New" or "Revised" License
64 stars 62 forks source link

DF Manual Rolls: Additional Prompts for Damage During Criticals #407

Open VincerKaden opened 2 years ago

VincerKaden commented 2 years ago

Module DF Manual Rolls 2.3.1

Describe the issue When a critical is manually entered using the Pathfinder 1e (v 0.81.3) system on Foundry v9 build 280, the prompt for damage comes up an additional time.

To Reproduce Steps to reproduce the behavior:

  1. Manually enter a valid threat rating d20 roll
  2. For confirming the critical, enter any d20 number
  3. Answer the damage prompts. (For ease of troubleshooting, enter 1 for the first prompt, 2 for the second, 3, etc.). You'll note there are too many prompts
  4. View the output and note that not all of the prompts are used. For example, the non-critical damage uses the manually input damage roll of 1, while the critical damage uses the manually input damage of 3. (Thus skipping over the 2).

Expected behavior The number of damage dice prompts should simply be once for the standard damage roll and then again for the critical damage roll.

Screenshots (Optional) n/a

flamewave000 commented 2 years ago

This is most likely a system issue. It is probably making an additional roll in the background and throwing away the result. I can take a look, but I can never tell where a roll is coming from.