flamewave000 / dragonflagon-fvtt

DragonFlagon FoundryVTT Modules
BSD 3-Clause "New" or "Revised" License
64 stars 57 forks source link

DF Chat Enhancements: Public Roll icon is identical to core icon #415

Open weepingminotaur opened 1 year ago

weepingminotaur commented 1 year ago

When using the "Roll Buttons: Replace Roll Type Selector with Buttons" option, the Public Roll icon (dice) is identical to the core Foundry icon (dice) that appears just to its left. This is confusing for users. A different Public Roll icon would solve the problem.

darloth commented 1 year ago

Does that icon (the core Foundry icon) serve a purpose there on the chat panel? Is it appropriate for a module to flat out remove it? If so, perhaps that would be another potential solution? (I honestly thought it was a button for rolling dice, at first, but it doesn't seem to do anything obvious.)

weepingminotaur commented 1 year ago

Yeah, it doesn't seem to actually do anything, so maybe replacing it would be good (and free up space visually, never a bad thing).

flamewave000 commented 1 year ago

@darloth @weepingminotaur I originally wanted to remove it, but Dice Tray actually uses it to display their Dice Calculator tool, and given that module's popularity I didn't want to create a conflict. I didn't really think of it as being all that confusing though since one is an icon and the other is an actual button you can press.

oakbrad commented 1 year ago

This is indeed very confusing for some of my players since the icon is the same. We are using Dice Tray, so clicking the Foundry D20 is not just an icon - it's the button that opens the dice notation calculator. So there's two D20 buttons right next to each other that do different things.

Screen Shot 2023-03-07 at 13 35 55

I think using the D20 icon is not clear to the purpose of the 'Public Roll' setting. The D20 is used all over the Foundry UI to indicate an actual dice roll command (so makes sense for the Dice Tray calc to use it). The current GM, Blind, and Self icons all visually communicate the level of visibility, I would propose changing the 'Public Roll' icon to match that intention. I think something like MDI account-group would be a better choice, indicating that the roll is visible to all vs GM vs secret.

account-group