DF Chat Enhancements: Chat Images

[MrVauxs]

Conflicting Module(s)

• Chat Images

Describe the conflict

Roll Buttons: Use buttons style on all chat buttons: Roll Buttons: Replace roll type selector with buttons only: None of the above:

Expected behavior The buttons do not overflow.

[p4535992]

also seem to broke something when i applied the code !ci|https://i.imgur.com/xxx.jpg! on the chat i generate this outer html.

<div class="ci-message-image"><img src="<a href="><a class="hyperlink" href="https://i.imgur.com/xxx.jpg&quot;" target="_blank" rel="nofollow noopener">https://i.imgur.com/RAH98JT.jpg"</a> alt="Unable to load image"&gt;</div>

this is wrong src="<a href="> same for when i upload a image.

[flamewave000]

So DF Chat Enhancements is not meant to be used along side Chat Images as they both provide the same functionality. DFCE includes full standard Markdown support in chat, so you can use ![my image](https://i.imgur.com/xxx.jpg) and it will add that as an image to the chat.

If you wish to keep them both, please use the second styling option so as to not overflow the buttons.

Edit: To deal with the issue @p4535992 mentioned, you may need to also disable DFCE's Markdown support

[MrVauxs]

I will note that Chat Images also allows for image upload, so the functionality is not 100% the same. But I will see if there could perhaps be a PR done to bridge the gap on either side.

Edit: Looks like it's already reported by @p4535992 in here

[MrVauxs]

Note: PF2e Dorako UI has fixed this issue already.

[flamewave000]

@MrVauxs it looks like he does so by removing the D20 icon. Be warned that this will conflict with Dice Tray which uses that icon as a button to display the dice calculator. If you don't use Dice Tray, or care about using that feature, then Dorako is fine :+1:

[MrVauxs]

I have noticed and even noted that. I believe they said they enable the button back when Dice Tray is on, but I don't know how it conjucts with Chat Images.

Though in the end, I don't use Dice Tray lol

pon., 5 gru 2022, 00:09 użytkownik flamewave000 @.***> napisał:

@MrVauxs https://github.com/MrVauxs it looks like he does so by removing the D20 icon. Be warned that this will conflict with Dice Tray which uses that icon as a button to display the dice calculator. If you don't use Dice Tray, or care about using that feature, then Dorako is fine 👍

— Reply to this email directly, view it on GitHub https://github.com/flamewave000/dragonflagon-fvtt/issues/423#issuecomment-1336543956, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHUOGHBEAV7MCBXJLGNEXGTWLUQD3ANCNFSM6AAAAAASCQFTQA . You are receiving this because you were mentioned.Message ID: @.***>