search

flamewave000 / dragonflagon-fvtt

DragonFlagon FoundryVTT Modules
BSD 3-Clause "New" or "Revised" License
64 stars 62 forks source link

DF Module Buttons no longer hides buttons when switching layers (found with DF Curvy Walls) #431

Open kagedansa opened 1 year ago

kagedansa commented 1 year ago

Module DF Module Buttons 1.4.2

Describe the issue There are errors in the console log associated with "DF Curvy Walls 3.4.0". The visible effect in Foundry (V10.291) is that module buttons are no longer hidden when switching to other layers.

To Reproduce Steps to reproduce the behavior:

  1. Switch to wall layer
  2. Switch to other layer
  3. See error

Screenshots (Optional) grafik grafik grafik grafik

Cryotechnik commented 1 year ago

Commenting to get updates.

NelanaPrime commented 1 year ago

Noticing the exact same error, Even with no other modules installed.

tjlanza commented 1 year ago

I suspect this is caused by the enhancement added in 1.4.1; I rolled back to 1.4.0 manually and the buttons hide as expected.

DrMcCoy commented 1 year ago

Yeah, commit c8d6169dba29e2bdb54e8f7486fef6a5bc57bf1b is to blame. When I do a git revert on it in the current main, build and copy it, the buttons vanish again like they should.