flamewave000 / dragonflagon-fvtt

DragonFlagon FoundryVTT Modules
BSD 3-Clause "New" or "Revised" License
64 stars 59 forks source link

DF Chat Enhancements: Minor incompatibility with Cautious Gamemasters Pack #449

Open cs96and opened 1 year ago

cs96and commented 1 year ago

Module DF Chat Enhancements 4.1.0

Describe the issue When the "Display Send Button In Chat" option is enabled in DF Chat Enhancements and the CGMP module is enabled, the button appears in the wrong place and the chat box has a region of padding underneath.

Please see here for more details https://github.com/cs96and/FoundryVTT-CGMP/issues/20

To Reproduce Steps to reproduce the behavior:

  1. Enable both DF Chat ENhancements and CGMP modules
  2. In Chat Enhancements settings, enable "Display Send Button In Chat"

Expected behavior The send button should appear at the bottom right, and there should not be a large area of padding underneath the chat box.

Screenshots (Optional) image

This is due to the send button trying to set the float: right css property, but you can't float things inside a flex container. CGMP changes the chat-form into a flex container so that it can make the typing notification appear and disappear.

I'm not much of a CSS expert, and I don't really know how to fix this, but it appears to me that this would need to be fixed in the DF Chat Enhancements module, not in CGMP.