flamewave000 / dragonflagon-fvtt

DragonFlagon FoundryVTT Modules
BSD 3-Clause "New" or "Revised" License
64 stars 62 forks source link

DF Manual Rolls: Bypass Dice So Nice when manual roll entered #455

Open this-gavagai opened 1 year ago

this-gavagai commented 1 year ago

I really want to thank you for these modules, especially Manual Rolls. I was reluctant to incorporate Foundry into in-person games because I didn't want to lose that feeling of sitting around a table, but Manual Rolls has been the keystone to being able to blend these approaches together.

One question I've had: I control the game from a laptop, and project the map onto a screen behind me. Players have paper character sheets and real dice. I use Foundry + Dice So Nice for GM rolls. In this scenario, is there any way to tell foundry/manual rolls to activate the 3d effects of Dice So Nice only for system rolls and not manual rolls?

I'm just learning Foundry module development, but if this is potentially a desirable feature I'm eager to dig in with a pull request if I can figure it out. Any tips on how to approach this problem would be greatly appreciated.

flamewave000 commented 1 year ago

So there's not at the moment. From my understanding, the way DSN works is that it monitors the chat log and when a chat message with isRoll=true comes in, it grabs the roll object associated with the message and uses it's DiceTerms to figure out what kind of dice were used and how many. If you wanted to prevent it from showing manual rolls, the Manual Rolls module would need to somehow add a Flag to the Roll object and then you would have to patch DSN so that it can detect this flag and ignore the roll.

this-gavagai commented 1 year ago

Thanks, this is extremely helpful. I'll poke around on the DSN side and see what I can find.