flamewave000 / dragonflagon-fvtt

DragonFlagon FoundryVTT Modules
BSD 3-Clause "New" or "Revised" License
64 stars 59 forks source link

DF Curvy Walls: Circle Segments don't work anymore with Foundry VTT V11 #487

Open DrMcCoy opened 1 year ago

DrMcCoy commented 1 year ago

Module DF Curvy Walls v3.4.0, with Foundry VTT 11.307 and Pathfinder 1e 9.4.

Describe the issue When drawing a circle and moving the blue thingie to create an open sergment / circle segment, the circle becomes broken. It wobbles between one and two or so segments instead of the segments you selected.

Similarily, the box is missing one wall segment.

To Reproduce Steps to reproduce the behavior:

  1. Click on any wall drawing tool
  2. Click on circle
  3. Draw a wall circle
  4. Move the blue handle
  5. See the circle become messed up

When clicking on the "X" to dismiss the circle and drawing a new circle, it's still broken. Only when moving the blue handle to the initial, full-circle position, dismissing the circle and then drawing a new one, only then there is a working full circle again.

The "brokenness" state of the circle tool also affects the box tool. When the circle is non-broken, the box tool draws a box with the left wall missing. When the circle is in a broken state, the box tool draws boxes with more walls (or even all walls) missing. Doing the above steps to fix the circle tool also re-instates the box tool (with "only" the left wall missing).

Expected behavior The circle should slice correctly.

Screenshots (Optional)

Screenshot 2023-08-04 at 00-38-22 Foundry Virtual Tabletop

This should such a broken circle. The blue handle is moved to due west, which should result in a half-circle. It also says it's drawing 11 segments. But only one segment is actually drawn.

The console shoulds a few deprecation errors: Error: event.data.origin is deprecated in favor of event.interactionData.origin. Error: event.data.destination is deprecated in favor of event.interactionData.destination. But those should still work in V11, only to be removed in V12.