flamewave000 / dragonflagon-fvtt

DragonFlagon FoundryVTT Modules
BSD 3-Clause "New" or "Revised" License
64 stars 62 forks source link

Fix #488, 483, 470, 453, 443: manual rolls for damage rolls #493

Open George1044 opened 1 year ago

George1044 commented 1 year ago

This was done on the PF2e system and their rolling data structures, not sure if this fix works for other systems. Likely: fixes #488, fixes #483, fixes #470, fixes #453, fixes #443

Guldred commented 1 year ago

@George1044 Since @flamewave000 seems not to be active on this right now, could you possibly upload a temporary compiled fixed version of the module? I wanted to compile your fix for myself, but Windows has issues with it and I currently do not have my Mac around.

tcm151 commented 1 year ago

@Guldred I was able to get my WSL setup working and sort of hack my way through it, here is the zip file with the updated fixes. I have tested it in my own game, and it does indeed prompt for rolls on damage now 🙏

df-manual-rolls.zip

Guldred commented 1 year ago

@tcm151 Nice, thank you! Was going to try on a mac next week but thats redundant now!

dbavirt commented 1 year ago

When might we see this merge complete and a release created?