search

flamewing / flamedriver

Upgraded S3&K sound driver
https://github.com/flamewing/flamedriver-skdisasm
Other
14 stars 5 forks source link

Add FM volume attenuation clamping #12

Closed Clownacy closed 3 years ago

Clownacy commented 3 years ago

This saves a couple of instructions.

Clownacy commented 3 years ago

This PR's been updated to add proper FM volume attenuation clamping.

As I said in the commit message, I found a scenario where you can hear FM volume attenuation overflow: get an extra life while Sonic 2's final boss music is playing.

flamewing commented 3 years ago

FYI, I am thinking on how to best do this.

flamewing commented 3 years ago

I am also noticing that zDoFMVolEnv does not respect the algorithm flags in TL, and ignores the track's volume.