SMPS Terminology needs updating - Githubissues

flamewing / flamedriver

Upgraded S3&K sound driver

https://github.com/flamewing/flamedriver-skdisasm

Other

12 stars 5 forks source link

SMPS Terminology needs updating #4

Open flamewing opened 6 years ago

flamewing commented 6 years ago

Music and SFX files need to be updated to use the new terminology. In a nutshell:

smpsAlterNote → smpsDetune
smpsAlterPitch → smpsChangeTransposition
smpsSetvoice → smpsFMvoice
smpsWeirdD1LRR → smpsMaxRelRate
smpsFMFlutter → smpsFMVolEnv

Reference commit: https://github.com/flamewing/flamedriver/commit/b483d9cc844f10d8316aba5f0d9bf62eebdb03f3#diff-39d6459915b1c59c6d3a4b3b40cb4ad2

flamewing commented 6 years ago

This depends on https://github.com/flamewing/flamedriver/pull/2.

flamewing commented 5 years ago

Terminology reference.

flamewing commented 5 years ago

Related to this issue: https://github.com/flamewing/mdtools/issues/5

Additional changes to dumped files:

smpsNoAttack → smpsHoldNote
smpsAlternameSMPS → smpsRawFreqMode
smpsSetvoice → smpsFMInstrument
smpsPSGvoice → smpsPSGInstrument
smpsHaltMusic → smpaMusicPause
smpsNoteFill → smpsNoteTimeout

Make same changes to _smps2asm_inc.asm, and add backward-compatibility wrappers.