search

flamewing / flamedriver

Upgraded S3&K sound driver
https://github.com/flamewing/flamedriver-skdisasm
Other
14 stars 5 forks source link

Getting Perfect in Special Stage kills music #6

Closed MainMemory closed 3 years ago

MainMemory commented 3 years ago

I've installed the Flamedriver in my hack, and when I get a Perfect in the Special Stage, instead of playing the sound effect, the music abruptly stops. Sound effects continue playing however, and the music comes back when it plays a new track. I tested your disassembly with the driver and it doesn't happen there. Example video

flamewing commented 3 years ago

The issue is that I decided to split music and sfx queues in Flamedriver, and S&K is horribly inconsistent on using music/sfx functions. The perfect jingle is actually a sfx, but it uses the music function (Play_Sound) instead of the sfx function (Play_Sound_2). Please see this commit for the changes needed to fix S3&K.

MainMemory commented 3 years ago

Okay, thank you.