search

flamewing / flamedriver

Upgraded S3&K sound driver
https://github.com/flamewing/flamedriver-skdisasm
Other
12 stars 5 forks source link

S&K Credits Music Broken/Unnecessary Duplicate Equates? #7

Open MainMemory opened 3 years ago

MainMemory commented 3 years ago

With the way the driver is currently set up, attempting to play the S&K credits theme will break the sound driver. This is because the equates used by the sound driver place the S&K credits music and the first sound effect on the same slot. Obviously this can be fixed by simply adjusting a few of these equates to be one higher than they are currently, but I'm wondering why we need them at all, when there are nearly identical ones in sonic3k.constants.asm. Is it just so the driver can be self-contained?

flamewing commented 3 years ago

Note what I did to mus_CreditsK definition on this commit to the S&K integration; this is still related to the split between music and SFX queues.

There are equates in the driver because when I wrote it, those equates did not exist in S3&K disassembly. Also, they won't necessarily exist in S1 or S2 disassemblies.

Although now that I think about it, I can probably check for the existence of those S1/S2/S&K equates using ifdef and do some sanity checks, such as the S&K credits song being among with the other songs.