flaming-cl / editorjs-text-color-plugin

https://flaming-cl.github.io/editorPlugin/
MIT License
50 stars 26 forks source link

this.popover.addEventListener is not a function #21

Closed ansarizafar closed 1 year ago

ansarizafar commented 1 year ago

I am trying to add color plugin to editorjs config but when I select a text block I get this error.

image

  Color: {
      class: ColorPlugin, // if load from CDN, please try: window.ColorPlugin
      config: {
         colorCollections: ['#EC7878','#9C27B0','#673AB7','#3F51B5','#0070FF','#03A9F4','#00BCD4','#4CAF50','#8BC34A','#CDDC39', '#FFF'],
         defaultColor: '#FF1300',
         type: 'text', 
         customPicker: true // add a button to allow selecting any colour  
      }     
    },
dogyun-wildseed commented 1 year ago

I upgraded to 2.0.2 version and I have same problem.

fmabid commented 1 year ago

So, the problem is with the new version of Chrome 114. I tested in FireFox and Chrome-113, there was no issue. @flaming-cl if possible then please look into this. Would be grateful. Thanks for this nice plugin.

flaming-cl commented 1 year ago

@dogyun-wildseed @ansarizafar @fmabid Hi, do you mind to provide more details about this issue? Here is a template for adding details. This will help us to better understand this issue, thanks.

Editorjs Version

2.25

Other unofficial Editorjs plugins you are using

If not, leave this blank

Device

PC

Operating System

Ubuntu / Windows / Mac

Browser

Chrome 114?

dogyun-wildseed commented 1 year ago

Yes, I have tested with most recent version. Not sure I could reproduce with in old eidtorjs version. (I will bring more info later)

Editorjs Version 2.27

Other unofficial Editorjs plugins you are using

Device M1 Mac book pro

Operating System Mac

Browser Chrome Version 114.0.5735.106 (Official Build) (arm64)

dogyun-wildseed commented 1 year ago

I can confirm it happend with Editorjs: 2.25 as well

Safrai

Works correctly

fmabid commented 1 year ago

Editorjs Version

2.27.0

Other unofficial Editorjs plugins you are using

Device

Lenovo IdeaPad S540

Operating System

Ubuntu

Browser

Version 114.0.5735.90 (Official Build) (64-bit)

peeter2 commented 1 year ago

I have the same problem. Please fix!

iwnow commented 1 year ago

Just need rename in src\picker\index.js this.popover to this.$popover Seems conflict with chrome popover implementation

fixed in https://github.com/flaming-cl/editorjs-text-color-plugin/pull/25

flaming-cl commented 1 year ago

Fixed in v2.0.4. Sorry for any inconvenience caused by this.