search

flammie / omorfi

Open morphology for Finnish
Other
84 stars 25 forks source link

ftb3-analysis duplicates numerals in base forms #44

Closed Traubert closed 6 years ago

Traubert commented 6 years ago

What happens:

hfst-lookup omorfi-ftb3.analyse.hfst > 123 123 112233 Num Digit Nom Sg 7.099609

What should happen:

hfst-lookup omorfi-ftb3.analyse.hfst > 123 123 123 Num Digit Nom Sg 7.099609

flammie commented 6 years ago

Ah I see what's going on, I can probably patch it quickly... Could you create a patch that bundles ftb3-analyse tests to automated travis-ci tests? Anything that is not covered by automated tests is going to be "unmaintained" and broken by updates all the time I'm afraid, especially when local testing would require nearly doubling the development build-test cycle time.

flammie commented 6 years ago

Check the feature/ftb3-digits branch out or apply the patch from the latest diff, I'll merge back to develop when the tests are available.

Traubert commented 6 years ago

Okay, thanks, something like https://github.com/flammie/omorfi/pull/49 - not sure how to bundle tests into Travis. Does it happen automagically maybe?

Traubert commented 6 years ago

That should be https://github.com/flammie/omorfi/pull/51 instead ..

flammie commented 6 years ago

generally anything that runs in make check works with travis, as I understand it's just some sort of virtual environment, it runs on ubuntu image and installs hfst from tino's repo and runs make and make check.

flammie commented 6 years ago

merged to develop, thanks for report and pr!