flammpfeil / SlashBlade_2

for mc1.14.4 or later
32 stars 19 forks source link

Having a slashblade on the hotbar is a resource hog trying to render it. #16

Open Cynix32 opened 2 years ago

Cynix32 commented 2 years ago

MC 1.16.5 Forge 36.2.2

Having slashblade on the hotbar can cause a significant tps and fps drop on low-end systems. I initially noticed it when I put the slashblade item on my hotbar, and my fps can sometimes stutter, and tps to sometimes randomly go haywire.

Here are some spark profiler screenshots pinpointing that a massive amount of time is spent just trying to render the slashblade item. You can see that the game is spending a lot of power for the slashblade function alone, the tps can also be affected. Screenshot (246) Screenshot (247)

Using performance mods such as sodium reforged can easily alleviate the problem. However, performance mods significantly interfere with the hit registration of slashblade, which is mentioned in a couple issues in this github. I am kinda stuck in a situation wherein I only have two choices: either suffer the fps/tps hell in order to use slashblade, or literally make slashblade unusable due to horrible hitreg when performance mods are installed.

Here is the spark profiler link for your reference. I only included ticks that are over 100ms, to really pinpoint the cause of my tps and fps drop, and this profiler points it to slashblade. https://spark.lucko.me/VKo0uyKyY3