flandreas / antares

Digital circuit learning platform
49 stars 6 forks source link

Text color lighter than expected when using Darcula theme #765

Closed logoliv closed 4 months ago

logoliv commented 4 months ago

Here's an example when I choose "green" as color, but it's the same for all colors when using this theme :

image

flandreas commented 4 months ago

@logoliv Thank you for pointing this out, I wasn't aware of this.

The reason why it currently behaves like that is that the text color has been hand-crafted for applications like rectangles with text, where there is a coloured background of the same color type. Obviously, this doesn't work very well with plain texts without background.

Screenshot 2024-06-22 at 15 13 36

I'll think about what a good strategy for choosing the text color in this use case could be. Maybe the background color..

flandreas commented 4 months ago

I'll go with the foreground (i.e. border) color:

Screenshot 2024-06-22 at 15 28 12
logoliv commented 4 months ago

nice 👍