search

flang-compiler / f18

F18 is a front-end for Fortran intended to replace the existing front-end in the Flang compiler
230 stars 48 forks source link

Support latest LLVM head with FIR - MLIR SideEffects interface change #1071

Closed jeanPerier closed 4 years ago

jeanPerier commented 4 years ago

Include new .td after LLVM changes: https://github.com/llvm/llvm-project/commit/0ddba0bd59c337f16b51a00cb205ecfda46f97fa

Tested to work with LLVM head https://github.com/llvm/llvm-project/commit/ecd3e678bbb11cf899603037ec2c5949b8d7fa6c from 2020-03-13 01:45 am PCT

Backwards compatible with previous known compatible heads at least back to https://github.com/llvm/llvm-project/commit/fde9d33f7101bac631b26990d17822474d3a34e9 from 2020-03-10, so need to update LLVM builds if they previously worked with FIR.

jeanPerier commented 4 years ago

LGTM. This has no functional change right? I think you should merge it asap if so.

From my reading of MLIR changes, I do not think there is a functional impact on FIR, but @schweitzpgi should probably confirm.

schweitzpgi commented 4 years ago

We will want to "modernize" FIR's effects along the lines River is going. This should enable us to share a common CSE framework, etc.