search

flang-compiler / f18

F18 is a front-end for Fortran intended to replace the existing front-end in the Flang compiler
230 stars 48 forks source link

Replace content of flang-compiler/f18 with "Moved" message #1072

Closed CarolineConcatto closed 4 years ago

CarolineConcatto commented 4 years ago

This patch replaces the content of flang-compiler-/f18 with a README.md file,as requested in task/issue[1].

The README includes instructions for migrating commits from local fork to LLVM and its new repository location.

Important: This patch will only be merged after the f18 was ported to LLVM monorepo according to task/issue[2].

[1]https://github.com/flang-compiler/f18/issues/908 [2]https://github.com/flang-compiler/f18/issues/876

Signed-off-by: Caroline Concatto caroline.concatto@arm.com

sscalpone commented 4 years ago

How did you test the migration processes that are outlined in the readme?

DavidTruby commented 4 years ago

How did you test the migration processes that are outlined in the readme?

I tested it using the flattened version of the repo I've been using to get ready for upstreaming. Once the CMake patch is merged I can re-flatten and push that out to my fork of llvm-project along with Eric's LLVM-side cmake changes. That should make it easy for people to test both the commands here and building F18/Flang in-tree with LLVM, as well as see what the flattened commit history will look like.

sscalpone commented 4 years ago

How about reducing this PR to just the message? It will be easier to review & keep correct. Then, after the upstream move, we can do another PR to remove all of the files.

RichBarton-Arm commented 4 years ago

I think there is a significant advantage in the commit history having the addition of the readme and the removal of the files as an atomic commit.

I don't think it will be hard to co-ordinate. If we can agree on the contents of the readme beforehand, David can update this PR after we push into LLVM and then someone with F18 commit access can merge it before commit access is shut off. There should be no risk of any changes taking place on the F18 side after we have merged into LLVM so it won't need rebasing.

DavidTruby commented 4 years ago

We also don't want the changed README going in to LLVM, so we have to do it all after we merge anyway

sscalpone commented 4 years ago

My point is that we can (easily) approve the text of the message now whereas we cannot audit the list of files to be deleted until after we've moved things to LLVM. My preference is to push README.md as soon as the code is moved to LLVM so there's no delay while we collect the list of files to be deleted.

With that, I'll defer to @CarolineConcatto on how to proceed.

CarolineConcatto commented 4 years ago

@sscalpone either way is fine. The solution to having only one PR is good for git history. As it will be only one PR for deleting and letting a message. If you are worried about the files, @DavidTruby and I could work together to guarantee that all the files that went in LLVM were also in the F18 project. Moreover, we could still review the Readme and later see the files, and only merge once we are happy about both. Not a problem for me. But you have the power to do the merge. So you have the word.

sscalpone commented 4 years ago

It is ok if the PR combines the changes to the README and the deletion of all files. We can finish the review after the PR after f18 is merged to llvm.org. The text in the README is ok now.