search

flang-compiler / f18

F18 is a front-end for Fortran intended to replace the existing front-end in the Flang compiler
230 stars 48 forks source link

Fix for typo in f18/test-lit/CMakeLists.txt #974

Closed Sameeranjoshi closed 4 years ago

Sameeranjoshi commented 4 years ago

I think the flag(FLANG_TEST_DEPENDS) may be getting neglected and not checking for dependencies.

Sameeranjoshi commented 4 years ago

Is this due to /bin doesn't have llvm-lit, is the -DLLVM_INSTALL_UTILS=ON set in while building llvm?

tskeith commented 4 years ago

With this change I get the following error from cmake:

CMake Error at /Users/tsk/llvm/f18-llvm/build/Release-clang-9/lib/cmake/llvm/AddLLVM.cmake:1546 (add_dependencies):
  The dependency target "flang" of target "check-all" does not exist.
Call Stack (most recent call first):
  /Users/tsk/llvm/f18-llvm/build/Release-clang-9/lib/cmake/llvm/AddLLVM.cmake:1567 (add_lit_target)
  test-lit/CMakeLists.txt:22 (add_lit_testsuite)

And a similar one for llvm-lit.

Does this require a change to the build instructions?

CarolineConcatto commented 4 years ago

I haven't noticed this problem before, but I have it also. The reason I did not see it was becasue make check-all works. Hey @Sameeranjoshi the fix for our problem is:

Remove from the FLANG_TEST_DEPENDS list: flang as it is not a target in f18. llvm-lit, FileCheck, count, not as we do not build these targets in f18. Probably the last ones will be added once we merge with LLVM, but for now, they are not a target in f18.

Sameeranjoshi commented 4 years ago

Thanks @CarolineConcatto @DavidTruby Closing issue as https://github.com/flang-compiler/f18/pull/1033 addresses the issue.