flanggut / smvs

Shading-aware Multi-view Stereo
BSD 3-Clause "New" or "Revised" License
250 stars 75 forks source link

Would you have a windows .exe available? #2

Open bsugerman opened 7 years ago

bsugerman commented 7 years ago

I am very interested in trying out this software as an alternative to dmrecon and scene2pset. Unfortunately my windows setup making it rather hard to compile the mve software. I see that you are working in Xcode so I imagine you are doing this all on a mac, but in case you have a windows executable, could you include it in your distribution?

Thanks!!!

-ben

flanggut commented 7 years ago

Hi! Thanks for your interest. Yes, I usually work with Ubuntu and macOS, and I never really worked with Windows so I don't feel comfortable supporting the OS. My guess is the code will probably compile without too many modifications but I cannot say for sure. I will try to find someone with Windows experience to test the code but for now there is only Unix and macOS. Sorry.

s-wtnb commented 7 years ago

hi. I succeeded in compiling SMVS on Windows 10 + VisualStudio 2015.

First, add SMVS to MVE's sln(https://github.com/andre-schulz/mve (CMake branch))

spherical_harmonics.h

//spherical_harmonics_9_0(T const* __attribute__((unused)) normal)
spherical_harmonics_9_0(T const* normal)

sgm_stereo.cc

//#include <popcntintrin.h> // for hamming distance
#include <nmmintrin.h>

or like this URL https://github.com/simonfuhrmann/mve/pull/212/files

block_sparse_matrix.h

//ldl_inverse(b.begin(), N);
ldl_inverse(b.data(), N);

libs/util/aligned_allocator.h(not SMVS but MVE) this not change but add const

template <class T_other, size_t alignment_other> bool operator== (AlignedAllocator<T_other, alignment_other> const&) const;
template <class T_other, size_t alignment_other> bool operator!= (AlignedAllocator<T_other, alignment_other> const&) const;

(of course, not only declaration but also definition)

.exe is here. https://github.com/flanggut/smvs/files/1473536/smvsrecon.zip

thanks.

flanggut commented 7 years ago

Thanks. I've added the changes to SMVS.

ErfolgreichCharismatisch commented 6 years ago

Please reupload the exe, @s-wtnb or include a cmake @flanggut

ErfolgreichCharismatisch commented 6 years ago

@flanggut "Thanks. I've added the changes to SMVS." Where?

flanggut commented 6 years ago

I added the changes here 733e662e37155d4bfdf2bf8d7367894f3b2b7457 I still won’t support Windows officially because I cannot debug or test on it.

MasterShockwave commented 6 years ago

Hi all, I'm new to building from source, I successfully built MVE for Win 10, but now wondering what @s-wtnb means by "First, add SMVS to MVE's sln". How do I achieve this exactly? Thanks guys!

s-wtnb commented 6 years ago

@MasterShockwave

  1. MVE's sln is created in the way written on MVE's wiki https://github.com/simonfuhrmann/mve/wiki/Build-Instructions-for-Windows https://github.com/andre-schulz/mve

  2. Create an smvs folder in the libs folder of MVE and embed the source in the smvs libs folder there

    MVE/
    |-- libs/
    |-- acc/
    |-- dmrecon/
    |-- etc.../
    |-- smvsrecon/
        |-- bicubic_patch.cc
        |-- bicubic_patch.h
        |-- etc...
  3. Do the same work in the apps folder

    MVE/
    |-- apps/
    |-- bundle2pset/
    |-- dmrecon/
    |-- etc.../
    |-- smvsrecon/
        |-- smvsrecon.cc
  4. Copy dmrecon's VisualStudio project file to the smvsrecon folder

    MVE/
    |-- apps/
    |-- smvsrecon/
        |-- smvsrecon.vcxproj(Original File is dmrecon.vcxproj)
    |-- libs/
    |-- smvsrecon/
        |-- mve_smvsrecon.vcxproj(Original File is mve_dmrecon.vcxproj)
  5. Open the two project files(smvsrecon.vcxproj, mve_smvsrecon.vcxproj) in a text editor and replace "dmrecon" with "smvsrecon"

  6. Open the MVE solution file in VisualStudio and add each of the two project files you copied

  7. Deleting dmrecon files of smvs project on Visual Studio, adding smvsrecon files, adding dependent files (mve_smvsrecon.lib etc)

  8. you can compile

thanks.

s-wtnb commented 6 years ago

@ErfolgreichCharismatisch I reuploaded. (exe is Compiled with Visual Studio 2017) smvsrecon.zip

MasterShockwave commented 6 years ago

That's awesome, thanks @s-wtnb! I actually had success very recently using a similar method, and I was going to post it all up, although I think yours is a bit cleaner! Thanks for sharing this in such detail, hopefully others can build now too! Happy to share my method if it helps others too! Cheers:)

nirmalsnair commented 5 years ago

@s-wtnb Could you upload a new .exe? The current one is outdated (built on May 15, 2017).