search

flanglet / kanzi

Fast lossless data compression in Java
Apache License 2.0
108 stars 18 forks source link

Mavenized project #11

Closed pschichtel closed 6 years ago

pschichtel commented 6 years ago

Quickly converted the project to a maven project and prepared it for maven central deployment.

flanglet commented 6 years ago

Could you set the version in the pom.xml to 1.4.0-SNAPSHOT and more importantly undelete build.xml (having support for maven is great but I still want to be able to build with ant) ?

pschichtel commented 6 years ago

Sure.

pschichtel commented 6 years ago

It was getting a little late yesterday, hence the short pr message. I checked the scripts you had around for building a android version. From what I've seen there are no Dependencies left that are not available on Android, so the scripts should be obsolete. the pom is also prepared for maven central deployment, but before that a groupid must be registered at sonatype. Alternatively I could deploy it to a group ID I have access to.

flanglet commented 6 years ago

Yes, the Android scripts are obsolete. You can remove them or I'll do it myself.

On Fri, Feb 16, 2018 at 10:28 AM, Phillip Schichtel < notifications@github.com> wrote:

It was getting a little late yesterday, hence the short pr message. I checked the scripts you had around for building a android version. From what I've seen there are no Dependencies left that are not available on Android, so the scripts should be obsolete. the pom is also prepared for maven central deployment, but before that a groupid must be registered at sonatype. Alternatively I could deploy it to a group ID I have access to.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/flanglet/kanzi/pull/11#issuecomment-366319067, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJ5hyp6eOQLbGoPBs8orAgK4Pf5GzClks5tVci7gaJpZM4SHt0N .

pschichtel commented 6 years ago

Rebased the branch, restored the build.xml and changed the version to 1.4.0-SNAPSHOT.

Last open question: What to do about the groupId ? Currently it's set to tel.schich.

flanglet commented 6 years ago

Hmmm. Not sure what to put in there. I do not want to have a reference to another branch/repo in the master so maybe I'll just put 'flanglet', Feel free to keep a different group ID in your clone it you want (but you'll have to keep it in mind if/when you sync). So change it or keep it and let me know when you are done.

On Sat, Feb 17, 2018 at 4:36 PM, Phillip Schichtel <notifications@github.com

wrote:

Rebased the branch, restored the build.xml and changed the version to 1.4.0-SNAPSHOT.

Last open question: What to do about the groupId ? Currently it's set to tel.schich.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/flanglet/kanzi/pull/11#issuecomment-366482773, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJ5h9zYJEQUhe3uMjRtGidO1ERmIv2Xks5tV3CGgaJpZM4SHt0N .

pschichtel commented 6 years ago

The typical convention is to use a domain name you own in reverse, e.g. com.flanglet if you own that domain.

flanglet commented 6 years ago

I know. I have not registered any domain so far.

On Sat, Feb 17, 2018 at 6:37 PM, Phillip Schichtel <notifications@github.com

wrote:

The typical convention is to use a domain name you own in reverse, e.g. com.flanglet if you own that domain.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/flanglet/kanzi/pull/11#issuecomment-366487974, or mute the thread https://github.com/notifications/unsubscribe-auth/ABJ5h8s8uPdWvNCLRL4257Hof5sbeXGBks5tV4zegaJpZM4SHt0N .

pschichtel commented 6 years ago

Ok, I've set it to io.github.flanglet.

The PR is ready now.

flanglet commented 6 years ago

Thanks. Merge is done.