flanksource / canary-checker

Kubernetes Native Health Check Platform
https://canarychecker.io
Apache License 2.0
200 stars 36 forks source link

refactor: rename 'enable' to 'enabled' in the helm chart #2297

Closed santilococo closed 3 weeks ago

santilococo commented 1 month ago

This MR updates the enable parameter in the helm chart from PR #2045 to enabled for consistency with the other parameters.

This change reduces confusion and standardizes the naming convention.

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

moshloop commented 3 weeks ago

Hi @santilococo - Thanks for the contribution, can you run make values.schema.deref.json README.md in the charts directory? That should fix the tests

santilococo commented 3 weeks ago

@moshloop, done. It changed the enable to enabled but also added several required: [] in the chart/values.schema.deref.json file. Let me know if I should remove these or make any other changes