search

flanksource / flanksource-ui

https://flanksource-ui.vercel.app
Other
8 stars 22 forks source link

fix: fix config changes filter by cell issues around encoding and colons #2012

Closed mainawycliffe closed 2 weeks ago

mainawycliffe commented 1 month ago

Fixes #1970 Fixes #2017

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
flanksource-ui ✅ Ready (Inspect) Visit Preview Jun 18, 2024 3:25pm
netlify[bot] commented 1 month ago

Deploy Preview for clerk-saas-ui ready!

Name Link
Latest commit 517a2fe1f044b41bcc32613fc982eea4bffb4871
Latest deploy log https://app.netlify.com/sites/clerk-saas-ui/deploys/6671a6460bbda1000873668e
Deploy Preview https://deploy-preview-2012--clerk-saas-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for goofy-euclid-75956c ready!

Name Link
Latest commit 517a2fe1f044b41bcc32613fc982eea4bffb4871
Latest deploy log https://app.netlify.com/sites/goofy-euclid-75956c/deploys/6671a646bb42af00080a467c
Deploy Preview https://deploy-preview-2012--goofy-euclid-75956c.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Deploy Preview for flanksource-demo-stable ready!

Name Link
Latest commit 517a2fe1f044b41bcc32613fc982eea4bffb4871
Latest deploy log https://app.netlify.com/sites/flanksource-demo-stable/deploys/6671a646084e7200089108c0
Deploy Preview https://deploy-preview-2012--flanksource-demo-stable.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

moshloop commented 3 weeks ago

@mainawycliffe I think the values need to be urlencoded, then combined with a , and url encoded again @adityathebe I think we todo the reverse, i.e. url decode the split match items

mainawycliffe commented 3 weeks ago

@moshloop @adityathebe what about instead of a GET request, we use post and body for the filters for this endpoint? This would eliminate the need for double encoding.