flanksource / flanksource-ui

https://flanksource-ui.vercel.app
Other
8 stars 22 forks source link

2031-In-health-page---on-first-load-we-hide-passing-ones-by-default-However-the-Hide-Passing-toggle-is-switched-off #2040

Closed mainawycliffe closed 1 week ago

mainawycliffe commented 2 weeks ago

Fixes #2031

vercel[bot] commented 2 weeks ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
flanksource-ui ✅ Ready (Inspect) Visit Preview Jun 26, 2024 2:09pm
netlify[bot] commented 2 weeks ago

Deploy Preview for flanksource-demo-stable ready!

Name Link
Latest commit 59454ff1821f8ce91ce2ae6988bc56194d9c3d35
Latest deploy log https://app.netlify.com/sites/flanksource-demo-stable/deploys/667c207004f1fd0008400c8a
Deploy Preview https://deploy-preview-2040--flanksource-demo-stable.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for clerk-saas-ui ready!

Name Link
Latest commit 59454ff1821f8ce91ce2ae6988bc56194d9c3d35
Latest deploy log https://app.netlify.com/sites/clerk-saas-ui/deploys/667c2070933a760008ba0e76
Deploy Preview https://deploy-preview-2040--clerk-saas-ui.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 2 weeks ago

Deploy Preview for goofy-euclid-75956c ready!

Name Link
Latest commit 59454ff1821f8ce91ce2ae6988bc56194d9c3d35
Latest deploy log https://app.netlify.com/sites/goofy-euclid-75956c/deploys/667c20700ba9a50008958068
Deploy Preview https://deploy-preview-2040--goofy-euclid-75956c.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

moshloop commented 1 week ago

@mainawycliffe this doesn't seem to work - The UI is taking it value from query params and the query is using local storage

Can we not just use atomWithStorage, I don't think hidePassing should update the URL state

mainawycliffe commented 1 week ago

@moshloop we can, but I thought when sharing a link, you would want to share exactly what you looking at in terms of state?

moshloop commented 1 week ago

@mainawycliffe - This doesn't seem to work - the toggle reflects the local storage state but the view does not