flanksource / github-app

1 stars 2 forks source link

Periodically cleanup offline runners #10

Open moshloop opened 4 years ago

philipstaffordwood commented 4 years ago

Would a k8s cron job suffice on the k8s side?

Should this include removing them from the Github side?

moshloop commented 4 years ago

This would be mainly on the github-side, on the runner side the pod should fail a liveness check if it is not connected to Github. A cronjob with a github-app runners cleanup would be sufficient for now

philipstaffordwood commented 4 years ago

Looks like L (maybe M).

Adding a cmd for github-app runners cleanup, maybe add a API route for it as well?