C++17 Build Failures - Githubissues

flann-lib / flann

Fast Library for Approximate Nearest Neighbors

http://people.cs.ubc.ca/~mariusm/flann

Other

2.25k stars 648 forks source link

C++17 Build Failures #387

Open adishavit opened 6 years ago

adishavit commented 6 years ago

C++17 removes the long deprecated (since C++11) std::binary_function and std::random_shuffle. FLANN does not build anymore of conforming C++17 compilers.

jslee02 commented 5 years ago

I believe this issue can be closed as the fix is merged.

libbooze commented 5 years ago

fyi the fix contains a performance bug... it constructs a heavy rng in every for iteration... It may not be noticable in practice but you probably want to fix it.