search

flannel-io / flannel

flannel is a network fabric for containers, designed for Kubernetes
Apache License 2.0
8.61k stars 2.87k forks source link

Add tolerations to the helm chart #1907

Closed manuelbuil closed 3 months ago

manuelbuil commented 3 months ago

Description

Flannel might deploy in clusters whose nodes contain taints and thus we need the tolerations field to be configurable

Todos

Release Note

None required
fungaren commented 3 months ago

This commit introduced a bug that not all taints are tolerated, at least the default taint for master node node-role.kubernetes.io/master:NoSchedule is not tolerated.

Please be careful if you are changing the behavior.

brandond commented 3 months ago

@fungaren the node-role.kubernetes.io/master label has been deprecated for quite some time, in favor of control-plane. In what environment do you still see this taint being set?

fungaren commented 3 months ago

@brandond I have an old Kubernetes cluster which is using 1.24. While upgrading flannel version the problem appeared. Now I have decide to add --set flannel.tolerations[0].effect=NoSchedule to address it.

Maybe it should not be considered as a bug, but it is indeed a breaking change.