taint node-role.kubernetes.io/master:NoSchedule not tolerated.

[fungaren]

Expected Behavior

The default taint for master nodes node-role.kubernetes.io/master:NoSchedule is not tolerated, and it makes flannel unable to be scheduled.

Current Behavior

This commit introduced this bug: https://github.com/flannel-io/flannel/pull/1907/files

Possible Solution

Add this to values.yaml:

  - key: "node-role.kubernetes.io/master"
    effect: "NoSchedule"

Or, just like the previous behavior, tolerate all taints.

Steps to Reproduce (for bugs)

1. 2. 3. 4.

Context

Your Environment

• Flannel version:
• Backend used (e.g. vxlan or udp):
• Etcd version:
• Kubernetes version (if used):
• Operating System and version:
• Link to your project (optional):

[manuelbuil]

This is a deprecated taint, it was replaced by "node-role.kubernetes.io/control-plane" several releases ago: https://kubernetes.io/docs/reference/labels-annotations-taints/#node-role-kubernetes-io-master-taint

[fungaren]

It is deprecated though, tolerate it will not produce any overhead. Keep it compatible is better, isn't it?

[rbrtbnfgl]

I think you can have the same behaviour if you change the toleration value through Helm.