feat: use mergo to merge values - Githubissues

flant / addon-operator

A system to manage additional components for Kubernetes cluster in a simple, consistent and automated way.

https://flant.github.io/addon-operator/

Apache License 2.0

483 stars 27 forks source link

feat: use mergo to merge values #380

Closed nabokihms closed 1 year ago

nabokihms commented 1 year ago

Overview

Use more popular more performant lib that is used by popular projects such as Kubernetes

What this PR does / why we need it

goos: darwin
goarch: amd64
pkg: github.com/flant/addon-operator/pkg/utils
cpu: Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
BenchmarkMarge/merge-12                      936           1205171 ns/op          769262 B/op      11710 allocs/op
BenchmarkMarge/mergo-12                     2169            584595 ns/op          128480 B/op       5552 allocs/op

Special notes for your reviewer

Does this PR introduce a user-facing change?

Use mergo to merge values.